Repository navigation
chore: deploy site via GitHub Pages under project path - #2
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015kFBiAzFDdHPc5j66PAw6H
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a68b8bd33d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Serve the site as a GitHub Pages project page at https://timintech.github.io/blitztextweb/ instead of a custom domain. - astro.config: site=timintech.github.io, base=/blitztextweb - central withBase() helper (src/utils/base.ts) for all internal links/assets - prefix canonical, hreflang, OG, sitemap, favicon, nav, footer, images - remove custom-domain / DNS / CNAME references (README, robots, meta) - privacy pages: name GitHub Pages / GitHub, Inc. as host with official refs - workflow: scope pages:write / id-token:write to the deploy job only, workflow and build run with contents:read Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rhz1aNuLb6REABNLkPSKNz
TimInTech
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ziel
Auslieferung der statischen Astro-Website ausschließlich über GitHub Pages als
Project Page unter:
https://timintech.github.io/blitztextweb/Keine Custom Domain, keine DNS-Schritte, keine
CNAME-Datei.Änderungen
GitHub-Pages-Unterpfad (Base-URL)
astro.config.mjs—site: 'https://timintech.github.io',base: '/blitztextweb'.src/utils/base.ts(neu) — zentralewithBase()-Behandlung; verhält sich ohnekonfiguriertes
baseneutral (Domain-Root).withBase()bzw.basepräfixiert: Canonical-,hreflang-, Open-Graph-, Sitemap- und JSON-LD-URLs, Favicon, Navigation, Footer,
Sprachumschalter, Impressum-/Datenschutz-Links, Logo, Screenshots und Tray-Icons.
Custom-Domain-Inhalte entfernt
blitztext.timintech.devollständig aus Code, Config,robots.txt, Meta-Daten undREADME entfernt; Ziel-URL überall auf
https://timintech.github.io/blitztextweb/.(GitHub, Inc.) benannt, mit Verweis auf die offizielle GitHub-Datenschutzerklärung
und GitHub-Pages-Dokumentation. Keine erfundenen Speicherdauern oder Vertragsangaben.
CNAME-Datei angelegt.Workflow-Berechtigungen (offener P2-Review-Hinweis)
.github/workflows/deploy-pages.yml: Workflow- und Build-Ebene nur mitcontents: read;pages: writeundid-token: writeausschließlich imDeploy-Job.
ci.yml(Build ohne Deploy);Deployment nur bei Push auf
mainoderworkflow_dispatch.Tests (lokal)
npm ci✅npm run check✅ (0 errors, 0 warnings, 1 hint — vorbestehend)npm run build✅ (6 Seiten nachdist/)git diff --check✅ ·dist/nicht getrackt ✅blitztext.timintech.de | CNAME blitztext | Custom Domain | DNS-Ziel→ nurREADME-Zeile „keine Custom Domain“ ✅
find … -name CNAME→ keine Datei ✅/blitztextweb/✅/blitztextweb/,/blitztextweb/en/,/blitztextweb/impressum/,/blitztextweb/datenschutz/,/blitztextweb/en/privacy/sowie Favicon/Screenshots→ alle HTTP 200;
/(Root) korrekt 404 ✅Rechtstext-Gate (getrennt vom Merge)
Das Impressum (
src/pages/impressum.astro) enthält weiterhin rechtlicherforderliche
[PLATZHALTER](Betreiber, Anschrift, Kontakt). Diese wurden bewusstnicht mit erfundenen Angaben gefüllt.
➡️ Der technische PR ist mergebar. GitHub Pages darf jedoch erst öffentlich aktiviert
werden, nachdem der Betreiber die Impressum-Platzhalter ausgefüllt hat. Merge und
Pages-Aktivierung sind getrennte Schritte.