Repository navigation
DDIR: declare the flatmap test's sum with enum - #1089
Merged
frankmcsherry merged 1 commit intoNov 14, 2026
Merged
Conversation
TimelyDataflow#1088's new test declared `type Member = User int | Group int;`, written before TimelyDataflow#1087 made `type` an alias and `enum` the sum declaration. The two merged separately, so master-next failed two tests in `tests/flatmap.rs`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H6wB4H99TLw4tqu4x48pXL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master-next fails two tests in
tests/flatmap.rsbecause #1087 and #1088 merged separately: #1088's new test declarestype Member = User int | Group int;, and after #1087 a sum is declared withenum.This changes that one line to
enum.A scan of every
.ddp, Rust, Python and Markdown file finds no othertypedeclaration of a sum, apart from the parser's own tests that check the error.cargo test --release -p interactiveon master-next with this change: 311 passed, 0 failed, 9 ignored (309 passed and 2 failed without it).🤖 Generated with Claude Code
https://claude.ai/code/session_01H6wB4H99TLw4tqu4x48pXL