fix: clean up script temp files on source failure (#1325) - #1326
Merged
Chemaclass merged 3 commits intoAug 21, 2026
Merged
Conversation
Two acceptance tests pin it: the sequential path, and --parallel --list, which reaches no end-of-run sweep and is why this call is not behind the is_enabled guard the other paths out of the loop use.
Chemaclass
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
bashunit::cleanup_script_temp_filescall on the source-failure path in the test discovery loop, matching what the bench loop already does.Problem
When a test file fails to source under
--no-parallel, the earlycontinueatsrc/runner/discovery.sh:134-136runsclean_set_up_and_tear_down_after_scriptandrestore_workdirbut skipscleanup_script_temp_files. Anybashunit::temp_filethe file created at top level before the failure survives the run.Fix
Added
bashunit::cleanup_script_temp_filesbetweenclean_set_up_and_tear_down_after_scriptandrestore_workdiron the source-failure path, matching the pattern already used insrc/runner/bench.sh:51.Verification
--parallelis not affected (its end-of-run loop already sweeps every id).Closes #1325