fix(ui5-icon): suppress native click propagation for Image mode - #13997
Open
NakataCode wants to merge 2 commits into
Open
fix(ui5-icon): suppress native click propagation for Image mode#13997NakataCode wants to merge 2 commits into
NakataCode wants to merge 2 commits into
Conversation
|
🚀 Deployed on https://pr-13997--ui5-webcomponents-preview.netlify.app |
NakataCode
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-interactive Image mode already suppressed the
ui5-clickcustom event, but the native click still bubbled up to the host, making the icon appear clickable to parent listeners.Calls
e.stopPropagation()in_onclickfor Image mode before returning, aligning runtime behavior with the documented@event("click")specification.Fixes: #13972