fix(ui5-option-group): remove unrelated inherited public APIs - #13998
Open
plamenivanov91 wants to merge 1 commit into
Open
fix(ui5-option-group): remove unrelated inherited public APIs#13998plamenivanov91 wants to merge 1 commit into
plamenivanov91 wants to merge 1 commit into
Conversation
ui5-option-group extended ui5-li-group and therefore inherited a number of public APIs that are irrelevant to grouping options inside a ui5-select and were never wired into its template: - headerAccessibleName property - wrappingType property - header slot - move and move-over events - header and title CSS parts Extract an abstract ListItemGroupBase that holds only the shared group contract (headerText, the default items slot, and the isListItemGroup / groupHeaderItem hooks the internal ui5-list relies on to flatten grouped items). Both ui5-li-group and ui5-option-group now extend this base, so the drag-and-drop, wrapping and header-slot APIs live solely on ui5-li-group where they belong, while ui5-option-group exposes only headerText and its options slot. ui5-li-group's public API is unchanged. Also add a standalone documentation page for ui5-option-group. Fixes #13992 Fixes #13991
|
🚀 Deployed on https://pr-13998--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui5-option-group extended ui5-li-group and therefore inherited a number of public APIs that are irrelevant to grouping options inside a ui5-select and were never wired into its template:
Extract an abstract ListItemGroupBase that holds only the shared group contract (headerText, the default items slot, and the isListItemGroup / groupHeaderItem hooks the internal ui5-list relies on to flatten grouped items). Both ui5-li-group and ui5-option-group now extend this base, so the drag-and-drop, wrapping and header-slot APIs live solely on ui5-li-group where they belong, while ui5-option-group exposes only headerText and its options slot.
ui5-li-group's public API is unchanged.
Also add a standalone documentation page for ui5-option-group.
Fixes #13992
Fixes #13991