[EMB-463] Bootstrap python-quality-control for Quad-Agent development parity - #22
Draft
Jelle Spijker (jellespijker) wants to merge 4 commits into
Draft
Conversation
Merge upstream master and bootstrap python-quality-control for Quad-Agent (Antigravity, Claude Code, GitHub Copilot, OpenCode) development parity. - Wire pre-commit hooks and talisman scanning - Establish rules bands in .agents/rules/ including custom rules for shipped runners and library consumer contracts - Configure hooks and exclusion files across all agent platforms
Jelle Spijker (jellespijker)
changed the title
Why: - The initial agentic bootstrap included generic firmware and hardware deployment residue (such as .swu image packaging and on-printer test execution) that does not apply to python-quality-control, which is purely a shared CI quality control submodule. - Pre-push bisect hook was failing due to false-positive test command assumptions (pytest finding 0 tests in cfg/). - Sibling consumer documentation in Rule 34 omitted 10+ consumers and did not trigger on runner scripts or linter configs. How: - Updated check_atomic_bisect_history.py to clear false test commands. - Rewrote AGENTS.md and GEMINI.md to accurately document python-quality-control as a shared CI submodule mounted across 14+ consumers. - Aligned Rule 04, Rule 15, and bootstrap-profile.json to reflect the quality verification workflow. - Updated Rule 34 (Library Consumer Contract) trigger paths and documentation to cover shell runners and linter configs across all consumers. - Integrated repository empirical observations (commit message bodies and commit size profiles) into Rule 01 and Rule 08. - Harmonized branch naming regex in git-branch-guard.py and refreshed .talismanrc checksums.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: EMB-463
Why
This PR bootstraps and synchronizes the
python-quality-controlrepository for Quad-Agent (Antigravity, Claude Code, GitHub Copilot, OpenCode) development parity, and applies thorough remediations discovered during an adversarial RED team review to tailor all orientation context, rules, and hooks strictly to the repository's role as a shared CI quality control submodule.What
.agents/,.claude/,.opencode/, and.github/.audit_quad_agent_parity.py.AGENTS.md,GEMINI.md):.swufirmware packaging, on-printer execution, and Qt/QML UI references).python-quality-controlis mounted as a git submodule atci/across 14+ UltiMaker services and libraries.15-shipped-runner-and-consumer-rules.md: Clarified that runner scripts (run_*.sh) and linter configs (cfg/) are the shipped surface executed in consumer checkouts rather than a local standalone test suite.34-library-consumer-contract-rules.md: Updated trigger glob to*.sh,cfg/*,local/*, and expanded documentation to list all 14+ downstream consumers (okuda,opinicus,dbus-interface-lib,libLogger,libCharon,print-process-reporting,misp-service,ultiLib,libSmeagol,mqttHandler,ebpf-io-logger,UMBusService, etc.).01-jira-commit-standards.md): Added explicit requirement for commit message bodies detailing why and how.08-scoped-changes-and-minimal-diffs.md): Documented empirical commit scope baseline (median 1 file per commit, 90th percentile 8 files).06-pull-request-lifecycle-rules.md): Aligned upstream base branch target toorigin/master.check_atomic_bisect_history.py: Cleared false-positive test commands sogit bisectpre-push validation passes without false failures on empty local test suites.git-branch-guard.py: Harmonized regex to support both hyphenated and underscore branch naming formats (EMB-463_nameandEMB-463-name)..talismanrc: Synchronized and refreshed checksums.How
AGENTS.mdand compiled down toGEMINI.mdviascripts/sync_agentic_configs.sh.python3 .agents/hooks/audit_quad_agent_parity.py .).bash scripts/verify_and_create_pr.sh.Verification & Validation (V&V)
scripts/verify_and_create_pr.sh)python3 .agents/hooks/audit_quad_agent_parity.py .)python3 .agents/hooks/compile_rule_frontmatter.py --check)python3 .agents/hooks/run_adversarial_audit.py)PR Checklist