Skip to content

[EMB-463] Ecosystem agentic rules cleanup and integration - #25

Draft
Jelle Spijker (jellespijker) wants to merge 5 commits into
masterfrom
EMB-463-agentic-rules-cleanup
Draft

[EMB-463] Ecosystem agentic rules cleanup and integration#25
Jelle Spijker (jellespijker) wants to merge 5 commits into
masterfrom
EMB-463-agentic-rules-cleanup

Conversation

@jellespijker

@jellespijker Jelle Spijker (jellespijker) commented Aug 20, 2026

Copy link
Copy Markdown
Member

Why

EMB-463 The agentic rules and hooks across the firmware ecosystem had drifted, containing irrelevant copy-pasted rules (Godot, cloud rules in UI, GCP Secret Manager) and lacking cross-repo invariants.

What

  • Cleaned up Godot and GCP text replacements.
  • Enforced correct docker test hooks.
  • Added cross-repo rules for Firmware Lifecycle, Error Code registries, and DBus interfaces.
  • Added submodule initialization check hooks.

How

Modifying .agents/rules and .agents/hooks, and running sync_agentic_configs.sh.

Verification & Validation

Verified that pre-commit hooks pass and verify_hooks_fire.py no longer blocks on cloud gates locally.

  • Initiating developer reviewed AI-generated code

Merge upstream master and bootstrap python-quality-control for Quad-Agent (Antigravity, Claude Code, GitHub Copilot, OpenCode) development parity.

- Wire pre-commit hooks and talisman scanning
- Establish rules bands in .agents/rules/ including custom rules for shipped runners and library consumer contracts
- Configure hooks and exclusion files across all agent platforms
Why:
- The initial agentic bootstrap included generic firmware and hardware deployment residue (such as .swu image packaging and on-printer test execution) that does not apply to python-quality-control, which is purely a shared CI quality control submodule.
- Pre-push bisect hook was failing due to false-positive test command assumptions (pytest finding 0 tests in cfg/).
- Sibling consumer documentation in Rule 34 omitted 10+ consumers and did not trigger on runner scripts or linter configs.

How:
- Updated check_atomic_bisect_history.py to clear false test commands.
- Rewrote AGENTS.md and GEMINI.md to accurately document python-quality-control as a shared CI submodule mounted across 14+ consumers.
- Aligned Rule 04, Rule 15, and bootstrap-profile.json to reflect the quality verification workflow.
- Updated Rule 34 (Library Consumer Contract) trigger paths and documentation to cover shell runners and linter configs across all consumers.
- Integrated repository empirical observations (commit message bodies and commit size profiles) into Rule 01 and Rule 08.
- Harmonized branch naming regex in git-branch-guard.py and refreshed .talismanrc checksums.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant