[EMB-463] Ecosystem agentic rules cleanup and integration - #25
Draft
Jelle Spijker (jellespijker) wants to merge 5 commits into
Draft
[EMB-463] Ecosystem agentic rules cleanup and integration#25Jelle Spijker (jellespijker) wants to merge 5 commits into
Jelle Spijker (jellespijker) wants to merge 5 commits into
Conversation
Merge upstream master and bootstrap python-quality-control for Quad-Agent (Antigravity, Claude Code, GitHub Copilot, OpenCode) development parity. - Wire pre-commit hooks and talisman scanning - Establish rules bands in .agents/rules/ including custom rules for shipped runners and library consumer contracts - Configure hooks and exclusion files across all agent platforms
Why: - The initial agentic bootstrap included generic firmware and hardware deployment residue (such as .swu image packaging and on-printer test execution) that does not apply to python-quality-control, which is purely a shared CI quality control submodule. - Pre-push bisect hook was failing due to false-positive test command assumptions (pytest finding 0 tests in cfg/). - Sibling consumer documentation in Rule 34 omitted 10+ consumers and did not trigger on runner scripts or linter configs. How: - Updated check_atomic_bisect_history.py to clear false test commands. - Rewrote AGENTS.md and GEMINI.md to accurately document python-quality-control as a shared CI submodule mounted across 14+ consumers. - Aligned Rule 04, Rule 15, and bootstrap-profile.json to reflect the quality verification workflow. - Updated Rule 34 (Library Consumer Contract) trigger paths and documentation to cover shell runners and linter configs across all consumers. - Integrated repository empirical observations (commit message bodies and commit size profiles) into Rule 01 and Rule 08. - Harmonized branch naming regex in git-branch-guard.py and refreshed .talismanrc checksums.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
EMB-463 The agentic rules and hooks across the firmware ecosystem had drifted, containing irrelevant copy-pasted rules (Godot, cloud rules in UI, GCP Secret Manager) and lacking cross-repo invariants.
What
How
Modifying
.agents/rulesand.agents/hooks, and runningsync_agentic_configs.sh.Verification & Validation
Verified that pre-commit hooks pass and
verify_hooks_fire.pyno longer blocks on cloud gates locally.