fix: generate capability role schemas from dotted defs - #94
Merged
carolinerg1 merged 1 commit intoSep 2, 2026
Merged
Conversation
carolinerg1
self-requested a review
September 2, 2026 17:45
carolinerg1
approved these changes
Sep 2, 2026
carolinerg1
merged commit Sep 2, 2026
c0c4a3b
into
Universal-Commerce-Protocol:main
17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Anyaliases for the container itselfWhy
common/identity_linking.jsondefinesdev.ucp.common.identity_linkingas a container withplatform_schemaandbusiness_schema. The old flattening path renamed the container as a single$defsentry, which generatedIdentityLinking1 = Anyand dropped the business-roleconfig.scopesconstraints from the SDK surface.The same container shape exists in
shopping/fulfillment.json, so regenerating the pinned 2026-08-25 models also restores those role models.Verification
./generate_models.sh 2026-08-25uv run python -m unittest tests.test_codegen_pipeline.SchemaNormalizationTest tests.test_codegen_pipeline.IdentityLinkingRoleSchemaTestuv run python -m unittest discover -s tests -p 'test_*.py'uv run ruff format --check preprocess_schemas.py tests/test_codegen_pipeline.pyuv run ruff check preprocess_schemas.py tests/test_codegen_pipeline.pygit diff --checkuvx pre-commit runhooks were run individually: trailing-whitespace, end-of-file-fixer, check-yaml, check-json, shebang hooks, ruff, ruff-format, prettier, shellcheck, and codespell passed. The localcheck-added-large-fileshook hung in pre-commit; equivalent verification found no newly added file over 500KB.