Repository navigation
Check the clients of a facade by KSP - #124
Open
reactivestudio wants to merge 1 commit into
Open
reactivestudio wants to merge 1 commit into
reactivestudio wants to merge 1 commit into
Conversation
reactivestudio
force-pushed
the
facade-ksp-client-rules
branch
from
November 16, 2026 11:52
3cd1ece to
8ce6c9b
Compare
reactivestudio
force-pushed
the
facade-ksp-supertype-markers
branch
from
November 16, 2026 11:52
1fa0998 to
29f1887
Compare
reactivestudio
force-pushed
the
facade-ksp-client-rules
branch
from
November 16, 2026 12:06
8ce6c9b to
a458759
Compare
reactivestudio
force-pushed
the
facade-ksp-supertype-markers
branch
2 times, most recently
from
November 16, 2026 12:07
8cf7d85 to
cddb5d2
Compare
reactivestudio
force-pushed
the
facade-ksp-client-rules
branch
2 times, most recently
from
November 16, 2026 12:15
3464cd7 to
f8d0551
Compare
reactivestudio
force-pushed
the
facade-ksp-supertype-markers
branch
2 times, most recently
from
November 16, 2026 18:19
9333d4a to
6432cfd
Compare
reactivestudio
force-pushed
the
facade-ksp-client-rules
branch
from
November 16, 2026 18:19
7f46013 to
9676e43
Compare
reactivestudio
force-pushed
the
facade-ksp-supertype-markers
branch
from
November 16, 2026 18:36
6432cfd to
2acd9cd
Compare
reactivestudio
force-pushed
the
facade-ksp-client-rules
branch
from
November 16, 2026 18:36
9676e43 to
9ff53d1
Compare
reactivestudio
force-pushed
the
facade-ksp-supertype-markers
branch
from
November 16, 2026 18:48
2acd9cd to
9f1ecad
Compare
reactivestudio
force-pushed
the
facade-ksp-client-rules
branch
from
November 16, 2026 18:48
9ff53d1 to
1913226
Compare
reactivestudio
force-pushed
the
facade-ksp-supertype-markers
branch
from
November 16, 2026 19:07
9f1ecad to
374f7cb
Compare
reactivestudio
force-pushed
the
facade-ksp-client-rules
branch
from
November 16, 2026 19:07
1913226 to
cfa6e0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Четвёртая часть процессора
semantic-pattern-ksp: правила клиентов фасада. Стоит поверх #123.Тип подсистемы в параметре, свойстве или результате называют только классы этой подсистемы или фасад, который её называет. Остальные получают ошибку:
AdminFileController names FileStorageClient of @FileSubsystem past a facade.Top-level функции и свойства не называют типы подсистем вовсе.
Класс подсистемы не берёт фасад своей подсистемы в параметре или свойстве. Вернуть его может: конфигурация отдаёт фасад из
@Bean-метода.Companion проверяется со своим классом, если сам не фасад: его метки — свои, не владельца.
Сгенерированные члены (свойства data class, члены делегата) пропускаются: они повторяют проверенные объявления.
Не проверяются тела функций и узкий интерфейс фасада: KSP не видит тел, у интерфейса нет аннотации. Оба ограничения записаны в README.
README: правило о своём фасаде уточнено, пример ошибки —
AdminFileController, пункты о проверяемых объявлениях.Правила проверяют
SubsystemAccessThroughFacadeChecker(к типам подсистемы — только через фасад) иSubsystemIndependentOfFacadeChecker(класс подсистемы не зависит от своего фасада).FacadeSymbolProcessorтеперь обходит и top-level функции и свойства.После этой части в плане остаётся проверка Spring при старте приложения.