Repository navigation
Read "if you've committed a crime this turn" - #428
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FFHHk3MFEhWxdBccQvEG7C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
Before: Outlaws of Thunder Junction's "if you've committed a crime this turn" (as an intervening-if trigger condition, or "as long as" on a static bonus) was listed as unsupported text. The engine fired "Whenever you commit a crime" but didn't remember that a crime had happened.
After: both wordings read. A crime (rule 700.13: targeting an opponent, or something of theirs) marks the player for the rest of that turn. The mark is saved with the game, so a match resumed later keeps it.
How:
GamePlayergainscrimeTurn, which loads as 0 from older saves. It is set whereGame::targetedTriggers()already detects a crime. Thecrimecondition compares it with the current turn and is shared byTextParser::interveningIf()andstaticCondition(). The new fixtures and test cover targeting your own creature (no crime) and an opponent, a save/load round trip, the end-step draw and expiry the next turn. Recognition only; the ledger's source pins are refreshed.Generated by Claude Code