Repository navigation
Read "each other non-Human creature" and "Creatures you control enter with an additional +1/+1 counter" - #430
Merged
Conversation
… with an additional +1/+1 counter" Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FFHHk3MFEhWxdBccQvEG7C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
Before: #429's entry-counter static read only "each other creature" and "each other Elf". "Each other non-Human creature you control enters with an additional +1/+1 counter on it." and "Creatures you control enter with an additional +1/+1 counter on them." were still listed as unsupported text.
After: both read. The "non-" form skips creatures of that type, and changelings count as that type. The form without "other" counts a creature with the ability itself too, as a permanent's own entry replacement does (rule 614.12).
How: the
TextParserkeyword now recordsothersorcreaturesand an optionalnon-type.Game::putOntoBattlefield()checks the entering creature's own keywords for thecreaturesform. The new fixtures and test cast Bears and Humans around a non-Human source and an enchantment. Recognition only; the ledger's source pins are refreshed.Generated by Claude Code