Repository navigation
Read "Whenever a player casts a … spell, … that player" - #431
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FFHHk3MFEhWxdBccQvEG7C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
Before: Ruric Thar's "Whenever a player casts a noncreature spell, CARDNAME deals 6 damage to that player." (and "… that player loses N life") was listed as unsupported text, because "that player" can be you.
After: it reads for creature, noncreature, artifact, enchantment, instant-or-sorcery and multicolored spells. "That player" is the spell's caster, whether that is an opponent or the permanent's own controller.
How:
TextParserreads the effect as aimed at a target player, then marks itthatPlayer. Forany_cast_kind,Game::trigger()resolves that player to the controller of the spell it was given. A new fixture and test cover a creature spell (nothing happens), a noncreature spell from the controller, and one from the opponent. Recognition only; the ledger's source pins are refreshed.Generated by Claude Code