Repository navigation
Read "Each opponent discards a card and loses N life" - #432
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FFHHk3MFEhWxdBccQvEG7C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
Before: "Each opponent discards a card and loses 2 life." and similar sentences (each player draws a card and loses 1 life, and so on) were listed as unsupported text, although each half read on its own.
After: a sentence where "each opponent" or "each player" does two of discard, lose life, mill, draw, sacrifice or gain reads as both actions in order, done by the same players.
How:
TextParser::sentenceEffects()splits the sentence into its two clauses, repeats the subject, and reads each clause with the existing rules. Targeted subjects ("Target opponent … and …") are left unread, because the second action would need the same target. A new fixture and test check that the opponent chooses the discard before losing the life. Recognition only; the ledger's source pins are refreshed.Generated by Claude Code