Repository navigation
Add paid chamber recovery transaction prerequisite - #150
Draft
valzargaming wants to merge 8 commits into
Draft
valzargaming wants to merge 8 commits into
valzargaming wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft adds the Phase 1 backend prerequisite for paid chamber-to-habitat recovery: detached gas/work calculation, paid assembly and Inventory ownership, fixed-budget jobs, reciprocal accounting, and four-owner publication guarded against stale or restored state. It adds no player pump commands, scheduler, UI, or physical presentation.
The accepted amendment is c198e59. Frozen Phase 1 head: f3f5094. Coordinator source review is required before device expansion.
The source-review correction requires full condition for start, resume and running batches. It adds pre-admission damaged-condition negatives and a whole-world reload regression after a genuinely charged batch, including retained audit/identity/budgets and fresh resume timing.
The startup correction replaces type-sensitive Dictionary equality for the pinned Inventory definition and Production bill with exact recursive shape/quantity validation. JSON integral floats are accepted; fractions, wrong types/values, missing/extra fields and reordered tags reject. Existing initialization order and canonical owner creation are unchanged. Authored transaction controls cover both actual Inventory-to-Tools fixture initializations and catalog negatives.
The mount correction emits a v1 root without closure fields and a v2 root with explicit is_open=true, matching the existing Inventory ledger contract. It preserves actual paid-route admission, support, capacity and cross-link validators. Authored assertions identify admission/support separately and check unchanged ledger version and original item identity/condition.
Pinned restore fields now use exact shape/number validation for assembly material bill, mounted capacity and anchor. Validated job summaries normalize joules/moles and compare exact numeric values. Authored JSON-roundtrip controls use actual mounted/admitted/charged route records, with changed/fractional/wrong-type/shape negatives. Charged full-world reload remains covered; the complete-record assertion compares full-precision decoded JSON values across owner-specific integral normalization. Four-owner CAS and reciprocal audit copy equality remain strict.
Validation at this head:
git diff --checkat this head; schema JSON syntax/identity check is reused from unchanged schemas at dd14acc.The milestone document records APIs, save16/Pressure6 migration, unchanged observation17/paid-door6 projection, publication boundary and remaining acceptance work. Old snapshots receive no pump, gas or energy grant.