Skip to content

Fix correctness, security, and reliability issues - #12

Merged
Varun-51 merged 3 commits into
mainfrom
fix/code-review-issues
Oct 15, 2026
Merged

Varun-51 merged 3 commits into
mainfrom
fix/code-review-issues

Conversation

@Varun-51

Copy link
Copy Markdown
Owner
  • TranslationRunner: move page COMPLETED status set into translatePage so markPageFailed's FAILED status is not overwritten by updateCounters
  • TranslationOrchestrator: initialize passes from block.retryCount() so the minStablePasses check survives job resume correctly
  • OllamaHttpClient: escape modelTag via objectMapper.writeValueAsString in both pull() and generate() to prevent JSON injection
  • ConnectionProvider: append journal_mode=WAL and busy_timeout=5000 to the JDBC URL to eliminate SQLITE_BUSY errors under concurrent writes
  • LicenseRepository: add domain port and JdbcLicenseRepository adapter so license acceptance persists across restarts; update SchemaInitializer

- TranslationRunner: move page COMPLETED status set into translatePage
  so markPageFailed's FAILED status is not overwritten by updateCounters
- TranslationOrchestrator: initialize passes from block.retryCount()
  so the minStablePasses check survives job resume correctly
- OllamaHttpClient: escape modelTag via objectMapper.writeValueAsString
  in both pull() and generate() to prevent JSON injection
- ConnectionProvider: append journal_mode=WAL and busy_timeout=5000 to
  the JDBC URL to eliminate SQLITE_BUSY errors under concurrent writes
- LicenseRepository: add domain port and JdbcLicenseRepository adapter
  so license acceptance persists across restarts; update SchemaInitializer
- Remove unused pageId parameter from updateCounters() to fix PMD violation
- Update LicenseServiceTest to inject in-memory LicenseRepository
- Add @FunctionalInterface to 7 single-method domain interfaces
- Split assignment-in-operand in TranslationRunner and PdfImageExtractor
- Extract local variables in OllamaHttpClient to fix line length violation
@Varun-51
Varun-51 merged commit af48b10 into main Oct 15, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant