Repository navigation
Fix correctness, security, and reliability issues - #12
Merged
Merged
Conversation
Varun-51
commented
Oct 15, 2026
Owner
- TranslationRunner: move page COMPLETED status set into translatePage so markPageFailed's FAILED status is not overwritten by updateCounters
- TranslationOrchestrator: initialize passes from block.retryCount() so the minStablePasses check survives job resume correctly
- OllamaHttpClient: escape modelTag via objectMapper.writeValueAsString in both pull() and generate() to prevent JSON injection
- ConnectionProvider: append journal_mode=WAL and busy_timeout=5000 to the JDBC URL to eliminate SQLITE_BUSY errors under concurrent writes
- LicenseRepository: add domain port and JdbcLicenseRepository adapter so license acceptance persists across restarts; update SchemaInitializer
- TranslationRunner: move page COMPLETED status set into translatePage so markPageFailed's FAILED status is not overwritten by updateCounters - TranslationOrchestrator: initialize passes from block.retryCount() so the minStablePasses check survives job resume correctly - OllamaHttpClient: escape modelTag via objectMapper.writeValueAsString in both pull() and generate() to prevent JSON injection - ConnectionProvider: append journal_mode=WAL and busy_timeout=5000 to the JDBC URL to eliminate SQLITE_BUSY errors under concurrent writes - LicenseRepository: add domain port and JdbcLicenseRepository adapter so license acceptance persists across restarts; update SchemaInitializer
- Remove unused pageId parameter from updateCounters() to fix PMD violation - Update LicenseServiceTest to inject in-memory LicenseRepository
- Add @FunctionalInterface to 7 single-method domain interfaces - Split assignment-in-operand in TranslationRunner and PdfImageExtractor - Extract local variables in OllamaHttpClient to fix line length violation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.