Fix Python and Rust memory leaks - #8437
Open
plafosse wants to merge 1 commit into
Open
Conversation
zznop
approved these changes
Aug 19, 2026
zznop
left a comment
zznop
left a comment
Member
There was a problem hiding this comment.
Your changes look good. However, looks like the C++ CoreTypeParser::ParseTypeString still has a failure path that leaks apiResult: https://github.com/Vector35/binaryninja-api/blob/test_fix_memory_leaks/typeparser.cpp#L588
plafosse
force-pushed
the
test_fix_memory_leaks
branch
from
August 19, 2026 15:18
dedca95 to
d891444
Compare
Member
Author
|
Oh good check. Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Python and Rust ownership issues reported in Vector35/binaryninja#1506. Ensures owned references and parse results are freed correctly on both success and failure paths.
Verified with Python compilation and Rust formatting/build checks.