Skip to content

Fix DEPRECATION_HORIZON sed pattern in script/release #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joelhawksley wants to merge 1 commit into from
+5 −2
Closed

Fix DEPRECATION_HORIZON sed pattern in script/release #2704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions script/release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,13 @@ update_ruby_version() {
-e "s/PATCH = [0-9]+/PATCH = $3/g" \
lib/view_component/version.rb

# Update deprecation horizon version
# Update deprecation horizon version. deprecation.rb stores the value
# as a quoted string (e.g. "4.0.0"), so match/replace the full quoted
# X.Y.Z — the previous [0-9]+ pattern matched no digits before the
# opening quote and silently no-oped on every release.
major=$1
sed -E -i '' \
-e "s/DEPRECATION_HORIZON = [0-9]+/DEPRECATION_HORIZON = $((major + 1))/g" \
-e "s/DEPRECATION_HORIZON = \"[0-9]+\.[0-9]+\.[0-9]+\"/DEPRECATION_HORIZON = \"$((major + 1)).0.0\"/g" \
lib/view_component/deprecation.rb
}

Expand Down
Loading