Repository navigation
fix(tls): decode encrypted_data of PKCS#8 keys as OCTET STRING - #31
Merged
Merged
Conversation
With pkcs8 0.11 the generic parameter of EncryptedPrivateKeyInfo is the type of the encrypted_data field. Using String made the decoder expect a UTF8String where RFC 5208 defines an OCTET STRING, so every password protected key sent by the broker failed to parse and the actor's local TLS server never started. The existing load_encrypted_key_with_password test was failing on master for this reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With pkcs8 0.11 the generic parameter of EncryptedPrivateKeyInfo is the type of the encrypted_data field. Using String made the decoder expect a UTF8String where RFC 5208 defines an OCTET STRING, so every password protected key sent by the broker failed to parse and the actor's local TLS server never started. The existing load_encrypted_key_with_password test was failing on master for this reason.