Repository navigation
build(windows): stop the build script when docker build or cargo buil… - #35
Merged
Merged
Conversation
…d fails build.ps1 did not check $LASTEXITCODE, so a failed docker build or a failed cargo build inside the container was ignored and the script went on, exiting with 0. The packaging step then aborted later on a missing binaries\udsactor-service.exe, far from the real error. This is the build script part of fix-time-sync-stop-borrow. The Rust part of that branch (binding the stop signal before select!) is already in master through 8e473d8, so this branch carries only the script change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d fails
build.ps1 did not check $LASTEXITCODE, so a failed docker build or a failed cargo build inside the container was ignored and the script went on, exiting with 0. The packaging step then aborted later on a missing binaries\udsactor-service.exe, far from the real error.
This is the build script part of fix-time-sync-stop-borrow. The Rust part of that branch (binding the stop signal before select!) is already in master through 8e473d8, so this branch carries only the script change.