Repository navigation
fix(gui): configure the surface again when it is outdated - #45
Merged
Merged
Conversation
get_current_texture() returns Outdated when the swap chain no longer matches the window, and wgpu expects configure() to be called before the next frame. The renderer only logged the error, and reconfigure() returns early when the size has not changed, so the RDP window stayed frozen while the log filled with 'Surface error: Outdated'. Lost is left as is: it needs the surface to be recreated, not configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_current_texture() returns Outdated when the swap chain no longer matches the window, and wgpu expects configure() to be called before the next frame. The renderer only logged the error, and reconfigure() returns early when the size has not changed, so the RDP window stayed frozen while the log filled with 'Surface error: Outdated'.
Lost is left as is: it needs the surface to be recreated, not configured.