Deep-link stock numbers for VDRC, NIG and Kyoto - #113
Merged
Conversation
FindStocks linked the stock number only for Bloomington and FlyORF,
mirroring what FlyBase's own stock report does. Three more centres do have
stable per-stock URLs, so build them:
- VDRC shop.vbc.ac.at/vdrc_store/<n>.html (chado's number is v<n>)
- Kyoto search_res_det.cgi?DB_NUM=1&DG_NUM=<n>
- NIG one detail view per stock type, chosen by the number's shape:
RNAi (rnaiDetailAction), knockout (koDetailAction), gRNA
(grnaDetailAction) and the redistributed TRiP lines, which are
looked up by tripNo rather than stockId.
The table therefore holds a list of (pattern, template) per collection
instead of one template, and a centre listed there whose number matches
none of its patterns now gets no link rather than falling through to the
chado order_url guess. Bloomington and FlyORF are unchanged.
Each pattern was checked against 25 stock numbers sampled at random from
that collection in chado, requiring HTTP 200 and the stock number present
in the page returned; every one of these sites answers 200 with an empty
shell for a number it does not hold, so the self-reference is the real
test. 74/75 passed: Kyoto 140166 has been withdrawn from the live
catalogue while chado still lists it as current, which is the same drift
that already leaves the odd FlyORF link dead.
Coverage of the whole stock catalogue goes from 94,583/168,212 (56.2%) to
159,127/168,212 (94.6%). Still unlinked: Korea Drosophila Resource Center
and the National Drosophila Species Stock Center, which offer only a search
box or species-level pages, and NIG's six SHA##### stocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FindStocks linked the stock number only for Bloomington and FlyORF, mirroring what FlyBase's own stock report does. Three more centres have stable per-stock URLs, so build them:
shop.vbc.ac.at/vdrc_store/<n>.html; chado's number isv<n>(uniformly, 26,479 of 26,479) and the shop drops thev.search_res_det.cgi?DB_NUM=1&DG_NUM=<n>.rnaiDetailAction, e.g.10052R-1,15513-3R-3,2381Ra-3,31794R-C-2), knockout (koDetailAction,M2L-2508), gRNA (grnaDetailAction,2LG-1995,2RG-0196), and the redistributed TRiP lines (HMJ/HMS/HMC/GL/JF), which are looked up bytripNorather thanstockId._STOCK_NUMBER_URLtherefore holds a list of(pattern, template)per collection instead of a single template, and a centre listed there whose stock number matches none of its patterns now gets no link rather than falling through to the chadoorder_urlguess. Bloomington and FlyORF are unchanged.Verification
Each pattern was checked against 25 stock numbers sampled at random from that collection in chado, requiring HTTP 200 and the stock number present in the page returned — every one of these sites answers 200 with an empty shell for a number it does not hold, so the self-reference is the real test. 74/75 passed; Kyoto 140166 has been withdrawn from the live catalogue while chado still lists it as current, the same drift that already leaves the odd FlyORF link dead.
Coverage
Stock-catalogue coverage goes from 94,583/168,212 (56.2%) to 159,127/168,212 (94.6%).
Still unlinked: Korea DRC and the National Drosophila Species Stock Center, which offer only a search box or species-level pages, and NIG's six
SHA#####stocks.