chore: update repo-platform template to build@a703906f0b72 - #61
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The required check migration cannot satisfy branch protection during rollout, and an existing CI topology test now fails.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the repo-platform template, centralizing CI and moving shared actions to the green-gated build branch.
Changes:
- Replaces local gate jobs with reusable fleet CI and an external
all-greenverdict. - Updates workflow action pins and Bun to 1.4.0.
- Refreshes template metadata while preserving local sections.
File summaries
| File | Description |
|---|---|
CONTRIBUTING.md |
Updates CI guidance. |
AGENTS.md |
Documents the new fleet CI model. |
.gitignore |
Refreshes managed-region metadata. |
.github/workflows/release.yml |
Moves release-health to @build. |
.github/workflows/nightly.yml |
Moves fuzz-issue actions to @build. |
.github/workflows/nightly-fuzz.yml |
Moves fuzz-issue actions to @build. |
.github/workflows/ci.yml |
Delegates gating jobs to fleet CI. |
.github/workflows/all-green.yml |
Adds the external verdict workflow. |
.github/repo-platform-manifest.json |
Updates ownership grammar, hashes, and provenance. |
.copier-answers.yml |
Advances the template revision. |
.bun-version |
Upgrades Bun to 1.4.0. |
Review details
- Files reviewed: 10/11 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Triage of the Copilot reviewAll three findings verified as correct. Disposition below; threads replied and resolved. Required check, on this head: Repo-owned test, in the failing
Two of the three are repo-owned (neither path appears in Diff safety was checked separately and is clean: no repo-owned file deleted or overwritten, the manifest gains exactly one entry ( |
|
Pushed The failing test is retired, not fixed. Nothing is left unguarded. The fleet machinery already covers what the test protected: Also corrected four repo-owned comments that described the same retired shape:
Verified locally on the new head: |
d5fdbf9 to
98b7308
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Repository checks still assert the removed in-run gate, and several preserved documentation sections describe the obsolete topology.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
.github/workflows/ci.yml:91
- This topology migration also leaves repository-owned guidance encoding the removed in-run gate:
.github/settings.yml:81-83saysall-greenis inci.ymlwith aneedslist, and.github/workflows/checks.yml:63-70saysreleaseneeds that job and skipped checks fail it. Those comments now contradict thisinfo-release/external-verdict design and should be updated with the migration.
info-release:
needs: [checks, ci]
- Files reviewed: 10/11 changed files
- Comments generated: 2
- Review effort level: Balanced
| ## CI | ||
|
|
||
| - CI gates on a single status check, `all-green`, which needs every gating CI job (the convention is documented in [repo-platform's all-green guide](https://github.com/vivswan/repo-platform/blob/main/docs/all-green.md)). | ||
| - CI gates on the `all-green` status check - a check run a verdict workflow creates after judging every gating CI job of a run plus the expected Copilot review of the head (the convention is documented in [repo-platform's all-green guide](https://github.com/vivswan/repo-platform/blob/main/docs/all-green.md)). |
| # other run, so ordinary main pushes and release-PR refreshes are | ||
| # never blocked. | ||
| - uses: Vivswan/repo-platform/actions/release-health@main | ||
| - uses: Vivswan/repo-platform/actions/release-health@build |
98b7308 to
aa6d83c
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The updated workflow topology is internally consistent, repository-local sections remain preserved, and all observed checks pass.
Review details
- Files reviewed: 13/14 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Automated template update from
Vivswan/repo-platform(build branch).fc67557build@a703906f0b72Review any merge conflicts and confirm repository-local sections were preserved before merging.
Note
This branch is regenerated on every sync run; manual commits
pushed to it are overwritten. Make fixes in a separate branch or
after merging.
Split-class files were rebuilt structurally over this update: the managed
half comes from a clean render at the new template ref, the
repository-local half byte-for-byte from the previous commit, and
copier's merged result for these files was discarded. Local edits inside
a managed half do NOT survive this rebuild (managed halves are
template-owned); such edits are reset and flagged below. Each bullet
names its file's actual disposition (not every file has previous content
to carry); verify each file's diff before merging:
.gitignore: repository-local region restored from the repository's copyAGENTS.md: repository tail re-appended below the fresh managed contentCONTRIBUTING.md: repository tail re-appended below the fresh managed contentSECURITY.md: repository copy kept whole (its managed content matches the render)One-run starter pin rollout: repo-platform's composite actions now ship on the green-gated
builddelivery branch instead of floating onmainor the retiredactionsbranch, but starter workflows are rendered once and repo-owned, so template sync cannot re-render their pins. This sync checked each starter for the retired fuzz-issue pins; arewroteline below is a byte-surgical port (only the exact pin token changed, every other byte is untouched), aleft aloneline is a hand-set pin this rollout never touches:.github/workflows/nightly-fuzz.yml: rewrote 2 occurrence(s) ofVivswan/repo-platform/actions/fuzz-issue@maintoVivswan/repo-platform/actions/fuzz-issue@build.github/workflows/nightly.yml: rewrote 2 occurrence(s) ofVivswan/repo-platform/actions/fuzz-issue@maintoVivswan/repo-platform/actions/fuzz-issue@build