Repository navigation
Stop fractured noise from mirroring across x = z - #1264
Draft
piexelated wants to merge 1 commit into
Draft
piexelated wants to merge 1 commit into
piexelated wants to merge 1 commit into
Conversation
- Read each composite fracture axis from its own reseeded generator at unswapped coordinates in IrisNoiseGenerator and the batched NoiseLayerProgram - Read the datapack exporter's z warps at unswapped coordinates - Add a mirror test for the composite fracture and move the fracture test reference to per-axis seeds - Retake NoiseSeedCohesionTest (Linux/Windows digest), IrisCaveCarver3DCellKernelTest PACK_SHARED and three IrisMathNoiseHotPathParityTest values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs VolmitSoftware/VolmLib#3 merged first. It adds
CNG.reseededForAxisandCNG.fractureAxisSeed, and this PR does not compile against VolmLib master.Composite fractures read the z warp at swapped coordinates (z, x), so every fractured generator was a mirror image of itself across x = z. This is the Iris half of the VolmLib fix:
IrisNoiseGeneratorand the batchedNoiseLayerProgramread each fracture axis from the generator reseeded for that axis, at the same coordinates. A reseeded generator shares its nested fracture, so both axes of a level read the same warped coordinates. The deep-chain path and the batch program cost the same number of samples as before.Fractured terrain changes for existing worlds. This is a plain fix with no compatibility flag.
Tests, run against the VolmLib #3 branch:
IrisNoiseGeneratorFractureMirrorTest(new),IrisNoiseGeneratorFractureTest,NoiseSeedCohesionTest,NoiseStyleContractTest,IrisMathNoiseHotPathParityTest,IrisCaveCarver3DCellKernelTest,SmoothNoiseFidelityTest. 45 tests, 0 failures, 1 skipped. Deep chains still match the recursive reference bit for bit.NoiseStyleContractTestandSmoothNoiseFidelityTestpass unchanged.Retaken on Linux: the Linux/Windows digest in
NoiseSeedCohesionTest, theIrisCaveCarver3DCellKernelTestPACK_SHARED hash and write count, and threeIrisMathNoiseHotPathParityTestvalues.PINNED_HASH_MACis not retaken and will fail on macOS until someone reruns it there.Not rerun after switching to the per-axis API: the wider exporter suite (
pack.datapack.export.*) and the pack suites.