Add H3 POI attribution and passthrough aggregation - #435
Open
paco-barreras wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Grid-Based stop tables can contain H3 containment areas without coordinates, but visit attribution previously required point geometry. Direct stop-table APIs also could not forward custom passthrough aggregation, forcing callers back to label APIs and external summarization.
What changed
poi_mapthat expands all POI geometries to intersecting cells at the input resolution, computes bounded grid distances with H3ronPy's native Arrow kernel, and returns aligned POI identifiers using existingpoi_mapconventions.passthrough_aggon all direct and per-user stop-table APIs and forward it only to stop summarization, including Grid-Based.Validation
22 passedintest_visit_location_detection.py25 passed, 1 xfailedintest_stop_detection_utils.py11 passedin the focused direct/per-user/Grid-Based stop-detection selectionCloses #433
Closes #434
This pull request includes code written with the assistance of AI. The code has not yet been reviewed by a human (remove this disclosure after human review).