Skip to content

chore: add metadata lint ci step #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trigg merged 1 commit into from
Nov 1, 2026
Merged

chore: add metadata lint ci step #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,25 @@ jobs:
wget https://raw.githubusercontent.com/WayfireWM/wayfire/master/uncrustify.ini
git ls-files | grep "hpp$\|cpp$" | xargs ../uncrustify/build/uncrustify -c uncrustify.ini --no-backup --replace
git diff --exit-code

lint-xml:
runs-on: ubuntu-latest

steps:
- name: Checkout Code
uses: actions/checkout@v4

- name: Install xmlstarlet
run: sudo apt-get update && sudo apt-get install -y xmlstarlet

- name: Check XML
run: |
find metadata -name "*.xml" -exec xmlstarlet val --well-formed {} +

- name: Check XML Format
run: |
while IFS= read -r file; do
echo "File : ${file}"
xmlstarlet fo --indent-tab "$file" > "${file}.tmp"
diff -u "$file" "${file}.tmp"
done < <(find metadata -name "*.xml*")
4 changes: 2 additions & 2 deletions metadata/dock.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<category>Shell</category>
<option name="css_path" type="string">
<_short>CSS Path</_short>
<default></default>
<default/>
</option>
<option name="autohide" type="bool">
<_short>Autohide</_short>
Expand Down Expand Up @@ -89,7 +89,7 @@
<default>20</default>
</option>
<option name="show_close" type="bool">
<_short>Show Close Animations</_short>
<_short>Show Close Animations</_short>
<_long>Keep all window icons for up to 2 seconds to allow CSS animations.</_long>
<default>true</default>
</option>
Expand Down
70 changes: 35 additions & 35 deletions metadata/locker.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@
<_name>Top Left</_name>
</desc>
<desc>
<value>top-center</value>
<_name>Top</_name>
<value>top-center</value>
<_name>Top</_name>
</desc>
<desc>
<value>top-right</value>
Expand Down Expand Up @@ -134,7 +134,7 @@
<default>center-center</default>
</option>
<option name="password_always" type="bool">
<_short>Always show</_short>
<_short>Always show</_short>
<default>false</default>
</option>
</group>
Expand All @@ -151,8 +151,8 @@
<_name>Top Left</_name>
</desc>
<desc>
<value>top-center</value>
<_name>Top</_name>
<value>top-center</value>
<_name>Top</_name>
</desc>
<desc>
<value>top-right</value>
Expand Down Expand Up @@ -193,7 +193,7 @@
<default>2em default</default>
</option>
<option name="pin_always" type="bool">
<_short>Always show</_short>
<_short>Always show</_short>
<default>false</default>
</option>
</group>
Expand All @@ -210,8 +210,8 @@
<_name>Top Left</_name>
</desc>
<desc>
<value>top-center</value>
<_name>Top</_name>
<value>top-center</value>
<_name>Top</_name>
</desc>
<desc>
<value>top-right</value>
Expand Down Expand Up @@ -260,7 +260,7 @@
<max>20</max>
</option>
<option name="fingerprint_always" type="bool">
<_short>Always show</_short>
<_short>Always show</_short>
<default>false</default>
</option>
</group>
Expand All @@ -276,8 +276,8 @@
<_name>Top Left</_name>
</desc>
<desc>
<value>top-center</value>
<_name>Top</_name>
<value>top-center</value>
<_name>Top</_name>
</desc>
<desc>
<value>top-right</value>
Expand Down Expand Up @@ -310,8 +310,8 @@
<default>top-right</default>
</option>
<option name="network_always" type="bool">
<_short>Always show</_short>
<default>true</default>
<_short>Always show</_short>
<default>true</default>
</option>
<option name="network_font" type="string">
<_short>Network Font</_short>
Expand Down Expand Up @@ -340,8 +340,8 @@
<_name>Top Left</_name>
</desc>
<desc>
<value>top-center</value>
<_name>Top</_name>
<value>top-center</value>
<_name>Top</_name>
</desc>
<desc>
<value>top-right</value>
Expand Down Expand Up @@ -374,8 +374,8 @@
<default>top-center</default>
</option>
<option name="clock_always" type="bool">
<_short>Always show</_short>
<default>true</default>
<_short>Always show</_short>
<default>true</default>
</option>
<option name="clock_font" type="string">
<_short>Clock Font</_short>
Expand All @@ -394,8 +394,8 @@
<_name>Top Left</_name>
</desc>
<desc>
<value>top-center</value>
<_name>Top</_name>
<value>top-center</value>
<_name>Top</_name>
</desc>
<desc>
<value>top-right</value>
Expand Down Expand Up @@ -438,7 +438,7 @@
<max>10</max>
</option>
<option name="weather_always" type="bool">
<_short>Always show</_short>
<_short>Always show</_short>
<default>true</default>
</option>
</group>
Expand All @@ -454,8 +454,8 @@
<_name>Top Left</_name>
</desc>
<desc>
<value>top-center</value>
<_name>Top</_name>
<value>top-center</value>
<_name>Top</_name>
</desc>
<desc>
<value>top-right</value>
Expand Down Expand Up @@ -498,7 +498,7 @@
<max>20</max>
</option>
<option name="user_always" type="bool">
<_short>Always show</_short>
<_short>Always show</_short>
<default>true</default>
</option>
</group>
Expand Down Expand Up @@ -529,8 +529,8 @@
<_name>Top Left</_name>
</desc>
<desc>
<value>top-center</value>
<_name>Top</_name>
<value>top-center</value>
<_name>Top</_name>
</desc>
<desc>
<value>top-right</value>
Expand Down Expand Up @@ -563,7 +563,7 @@
<default>bottom-right</default>
</option>
<option name="mpris_always" type="bool">
<_short>Always show</_short>
<_short>Always show</_short>
<default>false</default>
</option>
<option name="mpris_icon_size" type="double">
Expand Down Expand Up @@ -605,8 +605,8 @@
<_name>Top Left</_name>
</desc>
<desc>
<value>top-center</value>
<_name>Top</_name>
<value>top-center</value>
<_name>Top</_name>
</desc>
<desc>
<value>top-right</value>
Expand Down Expand Up @@ -653,7 +653,7 @@
<max>10</max>
</option>
<option name="battery_always" type="bool">
<_short>Always show</_short>
<_short>Always show</_short>
<default>true</default>
</option>
</group>
Expand All @@ -669,8 +669,8 @@
<_name>Top Left</_name>
</desc>
<desc>
<value>top-center</value>
<_name>Top</_name>
<value>top-center</value>
<_name>Top</_name>
</desc>
<desc>
<value>top-right</value>
Expand Down Expand Up @@ -703,7 +703,7 @@
<default>top-right</default>
</option>
<option name="volume_always" type="bool">
<_short>Always show</_short>
<_short>Always show</_short>
<default>false</default>
</option>
<option name="volume_icon_size" type="double">
Expand All @@ -726,8 +726,8 @@
<_name>Top Left</_name>
</desc>
<desc>
<value>top-center</value>
<_name>Top</_name>
<value>top-center</value>
<_name>Top</_name>
</desc>
<desc>
<value>top-right</value>
Expand Down Expand Up @@ -764,7 +764,7 @@
<default>default</default>
</option>
<option name="instant_unlock_always" type="bool">
<_short>Always show</_short>
<_short>Always show</_short>
<default>false</default>
</option>
</group>
Expand Down
8 changes: 4 additions & 4 deletions metadata/panel.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<_short>General</_short>
<option name="css_path" type="string">
<_short>CSS Path</_short>
<default></default>
<default/>
</option>
<option name="widgets_left" type="string">
<_short>Widgets Left</_short>
Expand All @@ -28,7 +28,7 @@
</option>
<option name="center" type="bool">
<_short>Center panel contents</_short>
<_long>Ensure the panel’s contents are centered. Effectively:
<_long>Ensure the panel&#x2019;s contents are centered. Effectively:
If full_span is on, it will put the left and right widgets next to the center ones.
If full_span is off, both sides of the panel will take the same amount of space, so that the center widgets are at the middle of the screen. This will lead to unused space on the side that has the least space taken up by the widgets.</_long>
<default>false</default>
Expand Down Expand Up @@ -271,7 +271,7 @@
<option name="menu_icon" type="string">
<_short>Menu Icon</_short>
<hint>file</hint>
<default></default>
<default/>
</option>
<option name="menu_icon_size" type="int">
<_short>Menu Icon Size</_short>
Expand Down Expand Up @@ -322,7 +322,7 @@
<option name="menu_logout_command" type="string">
<_short>Menu Logout Command</_short>
<_long>If not specified, a default logout interface will be used.</_long>
<default></default>
<default/>
</option>
<option name="logout_command" type="string">
<_short>Logout Button Command</_short>
Expand Down
Loading