Fix alignment in acquire-release spec test - #9014
Open
stevenfontanella wants to merge 3 commits into
Open
Conversation
tlively
approved these changes
Aug 18, 2026
| The entire iterator represents a complete expression using the `template`. e.g. | ||
| (drop (i32.atomic.load (i32.const 42))) | ||
| """ | ||
| if template.op == "atomic.fence": |
Member
There was a problem hiding this comment.
Can assert that the align is None here, too.
Member
Author
There was a problem hiding this comment.
I would lean towards not adding it since we’re not making use of the assumption here. It seems redundant because the Template is anyway the source of truth for the align, value_type, etc. e.g. we could also assert that value_type is None here, but we’d just be repeating what’s in the Template. I think the memory assertions make more sense here because they’re different arguments and it’s possible for the caller to use them incorrectly. Does that seem reasonable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions like
i32.atomic.load8_uhave a different alignment than the value of their argument. Add an extraalignfield to account for this.The value_type was also wrong for a few
loadoperations, but this didn't matter because loads don't use theirvalue_type; it's only used to choose what param to pass as the value for stores.cc @rmahdav