Repository navigation
ci: strip quotes when reading W9_VERSION for E2E sync - #2309
Merged
Merged
Conversation
16 active apps quote W9_VERSION in .env, so the E2E handoff rejected them as 'Could not determine a valid target version'. Strip matching outer quotes before validating the version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
W9_VERSIONbefore validating it.Why Changed
PR #2295 (dify 1.19.0) provisions an E2E server but failed with
Could not determine a valid target version for dify:apps/dify/.envstoresW9_VERSION='1.19.0', and 16 active apps quote the value the same way, so the handoff rejected them.Automated Validation
pytest tests/build tests/skills: 283 passed.Risk
Only affects the version string used for the appstore sync override; unquoted values are unchanged.