Skip to content

ci: strip quotes when reading W9_VERSION for E2E sync - #2309

Merged
zhaojing1987 merged 1 commit into
mainfrom
ci/e2e-env-version-quotes
Nov 17, 2026
Merged

zhaojing1987 merged 1 commit into
mainfrom
ci/e2e-env-version-quotes

Conversation

@zhaojing1987

Copy link
Copy Markdown
Collaborator

What Changed

  • The E2E handoff now strips matching outer quotes from W9_VERSION before validating it.
  • Regression test covers both single- and double-quoted values.

Why Changed

PR #2295 (dify 1.19.0) provisions an E2E server but failed with Could not determine a valid target version for dify: apps/dify/.env stores W9_VERSION='1.19.0', and 16 active apps quote the value the same way, so the handoff rejected them.

Automated Validation

  • pytest tests/build tests/skills: 283 passed.

Risk

Only affects the version string used for the appstore sync override; unquoted values are unchanged.

16 active apps quote W9_VERSION in .env, so the E2E handoff rejected them as
'Could not determine a valid target version'. Strip matching outer quotes
before validating the version.
@zhaojing1987
zhaojing1987 merged commit 6e9021f into main Nov 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant