Skip to content

fix(contentful): round fractional memory requirements up - #2313

Merged
zhaojing1987 merged 1 commit into
mainfrom
fix/contentful-memory-conversion
Nov 18, 2026
Merged

zhaojing1987 merged 1 commit into
mainfrom
fix/contentful-memory-conversion

Conversation

@zhaojing1987

Copy link
Copy Markdown
Collaborator

What Changed

Round positive fractional memory requirements up when constructing the integer Contentful payload. Keep the original application metadata unchanged and reject invalid memory values with the app and field name.

Why Changed

After #2312 was merged, the Contentful sync run stopped on YouTrack because the existing declaration "1.5" could not be passed directly to int().

Automated Validation

  • make test — 1,008 passed.
  • .venv/bin/python -m pytest cli/tests/test_contentful.py -q — 40 passed on the fix branch based on main.
  • .venv/bin/libs catalog-push --app youtrack --json — dry-run passed, with integer memory: 2; the same dry-run passed for zammad, zentao, and zulip.
  • Offline conversion passed for all 146 active and 230 archived app declarations.

Known Risk

No writes to Contentful were performed during validation. Merging this PR does not trigger the path-filtered Contentful sync because it only changes CLI code, tests, and docs.

Owner E2E Checklist

  • Use the fixed CLI to sync only youtrack, zammad, zentao, and zulip with an authorized Contentful connector.
  • Verify YouTrack shows memory 2 in Contentful and confirm the remaining three updates.

Issue: No separate issue supplied; regression surfaced after #2312.

AI Test Report: See Automated Validation and Known Risk above.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@zhaojing1987
zhaojing1987 merged commit 0e6e739 into main Nov 18, 2026
7 checks passed
@zhaojing1987
zhaojing1987 deleted the fix/contentful-memory-conversion branch November 18, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant