Repository navigation
fix(contentful): round fractional memory requirements up - #2313
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Round positive fractional memory requirements up when constructing the integer Contentful payload. Keep the original application metadata unchanged and reject invalid memory values with the app and field name.
Why Changed
After #2312 was merged, the Contentful sync run stopped on YouTrack because the existing declaration
"1.5"could not be passed directly toint().Automated Validation
make test— 1,008 passed..venv/bin/python -m pytest cli/tests/test_contentful.py -q— 40 passed on the fix branch based onmain..venv/bin/libs catalog-push --app youtrack --json— dry-run passed, with integermemory: 2; the same dry-run passed forzammad,zentao, andzulip.Known Risk
No writes to Contentful were performed during validation. Merging this PR does not trigger the path-filtered Contentful sync because it only changes CLI code, tests, and docs.
Owner E2E Checklist
youtrack,zammad,zentao, andzulipwith an authorized Contentful connector.2in Contentful and confirm the remaining three updates.Issue: No separate issue supplied; regression surfaced after #2312.
AI Test Report: See Automated Validation and Known Risk above.