Repository navigation
fix(ci): use R2 region for Appstore baseline downloads - #2314
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
--region autoto the Cloudflare R2 baseline lookup and downloads for the manifest, apps index, and checksum.AWS_DEFAULT_REGION=us-west-2and document the region choice.Why Changed
Appstore Publish failed with
InvalidRegionNamewhen the AWS CLI usedus-west-2. The baseline step now explicitly selects the R2 signing region, matching the existing uploader.Automated Validation
make test— passed: 1,008 tests (721 CLI, 271 build, 16 skills).git diff --check origin/main...fix/appstore-r2-baseline-region— passed.Known Risk
The change affects only baseline reads; it does not change artifact formats, checksum validation, or upload logic. Live R2 publishing has not been verified. Re-running the old failed run would use the original workflow revision.
Owner E2E Checklist
devworkflow run resolves the published R2 baseline and completes publishing.Issue: No linked issue. Failed workflow run.
AI Test Report: The mocked AWS CLI rejects regions other than
auto. The regression test covers first publication, an existing valid baseline, checksum failure, and storage failure. No live R2 writes were performed during validation.