Repository navigation
fix: accept 0.0.0.0 as a forward target on ports Charon does not use - #2000
Merged
Merged
Conversation
Proxy hosts that forward to 0.0.0.0 were left out of the generated config after the forward target checks tightened, because the address policy treats the unspecified address as blocked. On Linux it reaches this machine like 127.0.0.1, so forward targets now judge it as loopback. Charon's own ports stay refused, and probes and dials are unchanged. Fixes #1998
Contributor
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1998.
Problem
Since v0.51.0, proxy hosts that forward to
0.0.0.0:<port>are left out of the generated Caddy config with "Skipping proxy host: its forward target is not permitted by this proxy". The address policy allows loopback but treats the unspecified address as blocked. On Linux0.0.0.0reaches this machine like127.0.0.1, so this was a regression for setups where services publish ports on the host.Change
forwardLiteralBlockedhelper judges IPv40.0.0.0(including legacy spellings) as loopback. It is used by both forward target paths: config generation and the save-time check.AddressPolicy.Blocked, probes and dial-time checks are unchanged.0.0.0.0. Link-local, cloud metadata and::stay refused.docs/features/orthrus.mdupdated.Known limits
0.0.0.0are still refused at dial time.0.0.0.0is still refused at save.Tests
Unit tests cover accepted
0.0.0.0forms on ordinary ports, refusal on reserved ports, and the other blocked addresses.go test ./internal/services/ ./internal/caddy/ ./internal/network/passes.