Repository navigation
Conversation
GitHub-hosted runners are discarded after each job, so stopping the containers and removing their volumes only adds about 12 seconds to the job.
PHPUnit runs in the PHP container and uses the SQLite drop-in, so it doesn't need MySQL, nginx, WP-CLI, a WordPress installation, or the Gutenberg and Query Monitor plugins. The only thing it needed from "env:install" is "wp-tests-config.php", so "wp-setup.sh" now creates that file, and it is the last thing the script does. This also makes the file a better check for a finished setup than "wp-load.php", which exists right after cloning.
Installing the npm packages and building WordPress takes about 100 seconds of each WordPress CI job, and the result only changes when the WordPress branch moves or our setup changes. The cache includes Composer packages too, so that PHPUnit jobs don't depend on GitHub and Packagist being available.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress. Measurements will follow once CI has run with and without a cached setup.