-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Refine the admin menu view transition animation #11912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
westonruter
wants to merge
6
commits into
WordPress:trunk
Choose a base branch
from
westonruter:trac-65032-view-transition-improvements
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+96
−1
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8d83177
Refine the admin menu view transition animation.
westonruter 867f8e3
Render-block admin pages so View Transitions capture a complete page.
westonruter b5abf8d
Address PHPStan error: Function wp_get_view_transitions_admin_css() s…
westonruter 18a1fee
Merge remote-tracking branch 'origin/trunk' into trac-65032-view-tran…
westonruter 59f6402
Tests: Add unit tests for `wp_print_view_transitions_render_blocking_…
westonruter 93763e7
Merge branch 'trunk' into trac-65032-view-transition-improvements
westonruter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
tests/phpunit/tests/view-transitions/wpPrintViewTransitionsRenderBlockingLink.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <?php | ||
| /** | ||
| * Tests for the wp_print_view_transitions_render_blocking_link() function. | ||
| * | ||
| * @package WordPress | ||
| * @subpackage View Transitions | ||
| */ | ||
|
|
||
| /** | ||
| * @group view-transitions | ||
| * @covers ::wp_print_view_transitions_render_blocking_link | ||
| */ | ||
| class Tests_View_Transitions_wpPrintViewTransitionsRenderBlockingLink extends WP_UnitTestCase { | ||
|
|
||
| /** | ||
| * Tests that the hook for printing the render-blocking link is set up. | ||
| * | ||
| * @ticket 65032 | ||
| */ | ||
| public function test_hook(): void { | ||
| $this->assertSame( 10, has_action( 'admin_head', 'wp_print_view_transitions_render_blocking_link' ) ); | ||
| } | ||
|
|
||
| /** | ||
| * Tests that a render-blocking expect link is printed. | ||
| * | ||
| * @ticket 65032 | ||
| */ | ||
| public function test_prints_render_blocking_link(): void { | ||
| $output = get_echo( 'wp_print_view_transitions_render_blocking_link' ); | ||
|
|
||
| $processor = new WP_HTML_Tag_Processor( $output ); | ||
| $this->assertTrue( $processor->next_tag( 'LINK' ), 'Expected a LINK tag to be printed.' ); | ||
| $this->assertSame( 'expect', $processor->get_attribute( 'rel' ), 'Expected the LINK to have a rel of "expect".' ); | ||
| $this->assertSame( '#wpfooter', $processor->get_attribute( 'href' ), 'Expected the LINK to point at the footer.' ); | ||
| $this->assertSame( 'render', $processor->get_attribute( 'blocking' ), 'Expected the LINK to block rendering.' ); | ||
| $this->assertSame( '(prefers-reduced-motion: no-preference)', $processor->get_attribute( 'media' ), 'Expected the LINK to be scoped to the view transitions media query.' ); | ||
| $this->assertFalse( $processor->next_tag(), 'Expected only a single tag to be printed.' ); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.