Skip to content

Build/Test Tools: Restore the emptied theme-i18n.json. - #14977

Closed
Mamaduka wants to merge 1 commit into
WordPress:trunkfrom
Mamaduka:66340-restore-theme-i18n-json
Closed

Mamaduka wants to merge 1 commit into
WordPress:trunkfrom
Mamaduka:66340-restore-theme-i18n-json

Conversation

@Mamaduka

@Mamaduka Mamaduka commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

The Gutenberg sync in [64796] left src/wp-includes/theme-i18n.json empty. Content is unchanged from the pinned hash d72020a, so this restores it verbatim.

The build regenerates the file, so a deleted copy slips past git diff --exit-code as untracked; an empty tracked copy does not, hence the failing jobs on trunk.

The file should be synced from Gutenberg; the removal in the previous sync patch was due to an incomplete sync.

Trac ticket: https://core.trac.wordpress.org/ticket/66340
Prev PR: #14932

The Gutenberg sync in [64796] left `src/wp-includes/theme-i18n.json` empty. Content is unchanged from the pinned hash `d72020a`, so this restores it verbatim.

The build regenerates the file, so a deleted copy slips past `git diff --exit-code` as untracked; an empty tracked copy does not — hence the failing jobs on trunk.

See #66340.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@Mamaduka Mamaduka self-assigned this Oct 27, 2026
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mamaduka, jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Mamaduka
Mamaduka requested a review from sirreal October 27, 2026 07:31

@sirreal sirreal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is identical to the file I get on trunk when running npm ci ; npm run build:dev. Looks correct.

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 27, 2026
@github-actions github-actions Bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 27, 2026
@Mamaduka

Copy link
Copy Markdown
Member Author

Committed:

@Mamaduka Mamaduka closed this Oct 27, 2026
@Mamaduka
Mamaduka deleted the 66340-restore-theme-i18n-json branch October 27, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants