[rejaulalomkhan]

Description

Makes the data providers in tests/phpunit/tests/pluggable/ public static. PHPUnit 10+ requires static data providers, and none of these use instance state.

1. wpRand.php: data_wp_rand_should_return_a_non_negative_integer(), data_wp_rand_should_return_zero_when_min_and_max_are_zero()
2. signatures.php: get_defined_pluggable_functions(). Its direct call in test_all_pluggable_functions_exist() now uses self::. The get_pluggable_function_signatures() helper is not a provider and is left as is.

Testing

vendor/bin/phpunit --group pluggable
vendor/bin/phpunit -c tests/phpunit/multisite.xml --group pluggable
vendor/bin/phpunit --group pluggable --order-by=random --random-order-seed=12345
vendor/bin/phpunit --filter Tests_Pluggable_Signatures
vendor/bin/phpcs tests/phpunit/tests/pluggable/

All pass (324 tests in the group, 66 of them signature tests); PHPCS: no errors.

Trac ticket: https://core.trac.wordpress.org/ticket/66211

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Use of AI Tools

AI assistance: Yes
Tool(s): Google Antigravity (original change), Claude Code (review follow-up)
Model(s): Gemini 2.5 Pro, Claude Opus 5.5
Used for: Converting the providers, adding the missed signatures.php provider and running the tests. I reviewed every line and take responsibility for the change.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan, mukesh27, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[mukeshpanchal27]

Thanks, @rejaulalomkhan! The two changes in wpRand.php look good.

This PR misses one provider in this directory. get_defined_pluggable_functions() in tests/phpunit/tests/pluggable/signatures.php is a @dataProvider but is still non-static. Its body does not use $this, so it can become public static.

One test also calls it directly, at about line 60:

$defined = wp_list_pluck( $this->get_defined_pluggable_functions(), 0 );

This call still works after the change. For consistency, please update it to self::get_defined_pluggable_functions().

[mukeshpanchal27]

See my comment above.

[lancewillett]

I agree with @mukeshpanchal27: please include get_defined_pluggable_functions() in tests/phpunit/tests/pluggable/signatures.php in this directory-wide conversion. It is used as a @dataProvider and remains non-static. Make it public static and update its direct call in test_all_pluggable_functions_exist() to self::get_defined_pluggable_functions(). The separate get_pluggable_function_signatures() helper can stay as it is. Please include the existing signature tests in verification. The two wpRand.php conversions look correct.

_{AI review · gpt-6}

[Copilot]

🟡 Changes recommended

The directory-wide migration claim is inaccurate because signatures.php still has a non-static data provider, so either that provider must be migrated or the PR description narrowed.

1 open issue

• Make signatures.php pluggable provider static or narrow PR scope · New

What changed in this PR

This PR updates the two wp_rand() data providers to meet PHPUnit’s static-provider requirement without changing their datasets or test assertions.

Changes:

• Declares both data provider methods in wpRand.php as public static.
• Leaves the existing test cases and fixtures unchanged.

File	Description
tests/​phpunit/​tests/​pluggable/​wpRand.php	Makes both data providers static for PHPUnit compatibility.

_{Review effort: Balanced}

[rejaulalomkhan]

@mukeshpanchal27 @lancewillett get_defined_pluggable_functions() is now public static, and test_all_pluggable_functions_exist() calls it with self:: (545b066). The pluggable group passes on single site and multisite, including the 66 signature tests. I also corrected the description, which wrongly said the other files had no providers.

[lancewillett]

The missing signatures provider is now static and its direct caller uses self::. This addresses the earlier request.

Static checks passed. The affected classes passed together in randomized single-site and multisite runs: 408 tests and 1,383 assertions in each mode.

_{AI review · gpt-6}

[lancewillett]

PR #15176 landed in https://core.trac.wordpress.org/changeset/65128