Skip to content

Tests: Add unit coverage for get_comment_ID() and comment_ID() - #15276

Closed
shail-mehta wants to merge 2 commits into
WordPress:trunkfrom
shail-mehta:tests/get-comment-id-65819
Closed

shail-mehta wants to merge 2 commits into
WordPress:trunkfrom
shail-mehta:tests/get-comment-id-65819

Conversation

@shail-mehta

Copy link
Copy Markdown
Member

Trac ticket: #65819

What

Adds a dedicated PHPUnit class for get_comment_ID() and comment_ID(), covering ID retrieval from the global comment, the empty fallback, the filter, and display output.

Test-only; no production code changes.

Why

These helpers had no direct @covers coverage. Small helper coverage fits the #65819 test cleanup track.

How

Add tests/phpunit/tests/comment/getCommentID.php with @covers for both functions.

Testing Instructions

  1. npm run test:php -- --filter Tests_Comment_GetCommentID
  2. npm run test:php -- --filter Tests_Comment_GetCommentID -c tests/phpunit/multisite.xml
  3. npm run test:php -- --filter Tests_Comment_GetCommentID --order-by=random
  4. npm run test:php -- --group comment

Use of AI Tools

  • Cursor

Add unit tests for comment ID retrieval, empty fallback, filter, and display output.\n\nSee #65819.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The empty-fallback assertion remains order-dependent because it does not clear $GLOBALS['comment'] beforehand, allowing a stale comment ID from earlier tests to cause a failure.

1 open issue
What changed in this PR

Adds direct PHPUnit coverage for the comment ID helpers as part of the #65819 test cleanup effort. No production code changes are included.

Changes:

  • Tests ID retrieval from the global comment and the empty fallback.
  • Verifies filter customization and echoed output.
  • Adds explicit @covers annotations for both helpers.
File Description
tests/​phpunit/​tests/​comment/​getCommentID.php Adds fixtures and four tests for get_comment_ID() and comment_ID().

Review effort: Balanced

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for this test-only change adding PHPUnit coverage of the comment ID helpers.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@shail-mehta
shail-mehta marked this pull request as ready for review October 31, 2026 17:29
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests string ID and empty fallback. Current unset before the no-comment assertion fixes the reported order dependency.

Local randomized single-site and multisite checks passed with related existing tests: 51 tests, 319 assertions across this five-PR batch (seed 15273). PHPCS passed.

Optional: Echo and constant-filter exercises are lower value than the string-ID and empty-fallback cases; no further edge cases needed.

AI review · gpt-6

wporg-sync pushed a commit that referenced this pull request Oct 31, 2026
Verify comment email, URL, and ID retrieval and display, including global comment handling and filtered output.

Developed in: #15274, #15276, #15280

Props shailu25.
See #65819.


git-svn-id: https://develop.svn.wordpress.org/trunk@65137 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Oct 31, 2026
Verify comment email, URL, and ID retrieval and display, including global comment handling and filtered output.

Developed in: WordPress/wordpress-develop#15274, WordPress/wordpress-develop#15276, WordPress/wordpress-develop#15280

Props shailu25.
See #65819.

Built from https://develop.svn.wordpress.org/trunk@65137


git-svn-id: http://core.svn.wordpress.org/trunk@64286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@lancewillett

Copy link
Copy Markdown
Member

@shail-mehta
shail-mehta deleted the tests/get-comment-id-65819 branch November 2, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants