Skip to content

Editor: Allow CSS custom properties in wp_sanitize_block_gap_value(). Fixes #66427. - #15277

Closed
noruzzamans wants to merge 1 commit into
WordPress:trunkfrom
noruzzamans:trac-66427
Closed

noruzzamans wants to merge 1 commit into
WordPress:trunkfrom
noruzzamans:trac-66427

Conversation

@noruzzamans

Copy link
Copy Markdown
Member

Trac ticket: https://core.trac.wordpress.org/ticket/66427
Gutenberg PR: WordPress/gutenberg#82817

Description

Allows valid CSS custom property references (such as var(--wp--preset--spacing--32)) in wp_sanitize_block_gap_value().

When a theme defines a preset block gap in theme.json (such as styles.spacing.blockGap: "var:preset|spacing|32"):

  1. wp_get_global_styles() resolves the preset to its CSS variable format: var(--wp--preset--spacing--32).
  2. Candidate values for the global block gap in layout rendering are passed through wp_sanitize_block_gap_value().
  3. Because wp_sanitize_block_gap_value() disallows parentheses to prevent CSS injection, the resolved preset was rejected and returned null.
  4. As a result, Grid layout calculations in wp_get_layout_style() fell back to 0.5em instead of using the theme's preset gap value.
  5. In Grid blocks with columnCount and minimumColumnWidth, columns stack into a single column.

Testing Instructions

  1. Run PHPUnit test suite:
    npm run test:php -- tests/phpunit/tests/block-supports/layout.php
  2. Verify all tests pass including CSS variable preset sanitization and grid layout fallback.

@noruzzamans
noruzzamans marked this pull request as ready for review October 31, 2026 05:08
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props noruzzaman.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@tellthemachines tellthemachines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 65212
GitHub commit: f01d3b9

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants