Repository navigation
Tests: Add unit coverage for rest_output_rsd() - #15283
shail-mehta wants to merge 1 commit into
Conversation
Add unit tests for WP-API RSD element output and empty REST URL handling. See #65819.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for this tests-only change adding coverage for normal RSD output and the empty REST URL case.
No open issues 🎉
What changed in this PR
Adds direct PHPUnit coverage for rest_output_rsd() as part of the test cleanup tracked in #65819. This PR changes tests only; production behavior is unchanged.
Changes:
- Adds a dedicated test class with
@covers ::rest_output_rsd. - Verifies the WP-API RSD element includes the REST root URL.
- Verifies no output when the
rest_urlfilter returns an empty string.
| File | Description |
|---|---|
tests/phpunit/tests/rest-api/restOutputRsd.php |
Adds tests for normal RSD output and the empty REST URL early return. |
Review effort: Balanced
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
lancewillett
left a comment
There was a problem hiding this comment.
Checks the RSD discovery wire format and disabled-URL behavior; compact two-case coverage.
Local randomized single-site and multisite checks passed alongside related existing tests; PHPCS passed.
Optional: None necessary; no broad RSD matrix.
AI review · gpt-6
Verify the REST discovery link, RSD API element, and HTTP link header use the configured REST URL and are suppressed when that URL is disabled. Developed in: #15282, #15283, #15284 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@65140 602fd350-edb4-49c9-b593-d223f7449a82
Verify the REST discovery link, RSD API element, and HTTP link header use the configured REST URL and are suppressed when that URL is disabled. Developed in: WordPress/wordpress-develop#15282, WordPress/wordpress-develop#15283, WordPress/wordpress-develop#15284 Props shailu25. See #65819. Built from https://develop.svn.wordpress.org/trunk@65140 git-svn-id: http://core.svn.wordpress.org/trunk@64289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
PR #15283 landed in https://core.trac.wordpress.org/changeset/65140 |
Trac ticket: #65819
What
Adds a dedicated PHPUnit class for
rest_output_rsd(), covering the WP-API RSD element output and the empty REST URL early return.Test-only; no production code changes.
Why
rest_output_rsd()had no direct@coverscoverage. Small helper coverage fits the #65819 test cleanup track.How
Add
tests/phpunit/tests/rest-api/restOutputRsd.phpwith@covers ::rest_output_rsd.<api>RSD element with the REST root URLrest_urlis filtered to an empty stringTesting Instructions
npm run test:php -- --filter Tests_REST_API_RestOutputRsdnpm run test:php -- --filter Tests_REST_API_RestOutputRsd -c tests/phpunit/multisite.xmlnpm run test:php -- --filter Tests_REST_API_RestOutputRsd --order-by=randomnpm run test:php -- --group restapiUse of AI Tools