Skip to content

Tests: Add unit coverage for rest_output_rsd() - #15283

Closed
shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:tests/rest-output-rsd-65819
Closed

shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:tests/rest-output-rsd-65819

Conversation

@shail-mehta

Copy link
Copy Markdown
Member

Trac ticket: #65819

What

Adds a dedicated PHPUnit class for rest_output_rsd(), covering the WP-API RSD element output and the empty REST URL early return.

Test-only; no production code changes.

Why

rest_output_rsd() had no direct @covers coverage. Small helper coverage fits the #65819 test cleanup track.

How

Add tests/phpunit/tests/rest-api/restOutputRsd.php with @covers ::rest_output_rsd.

  • Outputs the WP-API <api> RSD element with the REST root URL
  • Outputs nothing when rest_url is filtered to an empty string

Testing Instructions

  1. npm run test:php -- --filter Tests_REST_API_RestOutputRsd
  2. npm run test:php -- --filter Tests_REST_API_RestOutputRsd -c tests/phpunit/multisite.xml
  3. npm run test:php -- --filter Tests_REST_API_RestOutputRsd --order-by=random
  4. npm run test:php -- --group restapi

Use of AI Tools

  • Cursor

Add unit tests for WP-API RSD element output and empty REST URL handling.

See #65819.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for this tests-only change adding coverage for normal RSD output and the empty REST URL case.

No open issues 🎉

What changed in this PR

Adds direct PHPUnit coverage for rest_output_rsd() as part of the test cleanup tracked in #65819. This PR changes tests only; production behavior is unchanged.

Changes:

  • Adds a dedicated test class with @covers ::rest_output_rsd.
  • Verifies the WP-API RSD element includes the REST root URL.
  • Verifies no output when the rest_url filter returns an empty string.
File Description
tests/​phpunit/​tests/​rest-api/​restOutputRsd.php Adds tests for normal RSD output and the empty REST URL early return.

Review effort: Balanced

@shail-mehta
shail-mehta marked this pull request as ready for review October 31, 2026 17:24
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks the RSD discovery wire format and disabled-URL behavior; compact two-case coverage.

Local randomized single-site and multisite checks passed alongside related existing tests; PHPCS passed.

Optional: None necessary; no broad RSD matrix.

AI review · gpt-6

wporg-sync pushed a commit that referenced this pull request Oct 31, 2026
Verify the REST discovery link, RSD API element, and HTTP link header use the configured REST URL and are suppressed when that URL is disabled.

Developed in: #15282, #15283, #15284

Props shailu25.
See #65819.


git-svn-id: https://develop.svn.wordpress.org/trunk@65140 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Oct 31, 2026
Verify the REST discovery link, RSD API element, and HTTP link header use the configured REST URL and are suppressed when that URL is disabled.

Developed in: WordPress/wordpress-develop#15282, WordPress/wordpress-develop#15283, WordPress/wordpress-develop#15284

Props shailu25.
See #65819.

Built from https://develop.svn.wordpress.org/trunk@65140


git-svn-id: http://core.svn.wordpress.org/trunk@64289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@lancewillett

Copy link
Copy Markdown
Member

@shail-mehta
shail-mehta deleted the tests/rest-output-rsd-65819 branch November 2, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants