Repository navigation
Tests: Add unit coverage for rest_output_link_header() - #15284
shail-mehta wants to merge 3 commits into
Conversation
Add unit tests for REST API Link header output and empty REST URL handling. See #65819.
There was a problem hiding this comment.
🟡 Changes recommended
The tests lack process isolation, causing bootstrap output to bypass the intended code paths, and the empty-URL test does not assert that headers remain unchanged.
2 open issues
What changed in this PR
Adds dedicated PHPUnit coverage for rest_output_link_header() as part of the REST API test cleanup in Trac #65819. No production code changes.
Changes:
- Adds a test class with explicit
@coversmetadata. - Checks response-body output with normal and empty REST URLs.
- Adds an Xdebug-dependent assertion for the REST API
Linkheader.
| File | Description |
|---|---|
tests/phpunit/tests/rest-api/restOutputLinkHeader.php |
Adds three tests for REST API link-header behavior. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Assert headers are unchanged when rest_url is empty, instead of only checking the response body. See #65819.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
lancewillett
left a comment
There was a problem hiding this comment.
The actual HTTP-header assertions passed locally with Xdebug enabled, in both single-site and multisite randomized runs. All three new methods executed with zero skips; PHPCS passed. The separate-process setup follows the existing header tests.
AI review · gpt-6
Verify the REST discovery link, RSD API element, and HTTP link header use the configured REST URL and are suppressed when that URL is disabled. Developed in: #15282, #15283, #15284 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@65140 602fd350-edb4-49c9-b593-d223f7449a82
Verify the REST discovery link, RSD API element, and HTTP link header use the configured REST URL and are suppressed when that URL is disabled. Developed in: WordPress/wordpress-develop#15282, WordPress/wordpress-develop#15283, WordPress/wordpress-develop#15284 Props shailu25. See #65819. Built from https://develop.svn.wordpress.org/trunk@65140 git-svn-id: http://core.svn.wordpress.org/trunk@64289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
PR #15284 landed in https://core.trac.wordpress.org/changeset/65140 |


Trac ticket: #65819
What
Adds a dedicated PHPUnit class for
rest_output_link_header(), covering empty body output, the empty REST URL early return, and the REST APILinkheader when xdebug is available.Test-only; no production code changes.
Why
rest_output_link_header()had no direct@coverscoverage. Small helper coverage fits the #65819 test cleanup track.How
Add
tests/phpunit/tests/rest-api/restOutputLinkHeader.phpwith@covers ::rest_output_link_header.rest_urlis filtered to an empty stringhttps://api.w.org/Link header (@requires function xdebug_get_headers)Testing Instructions
npm run test:php -- --filter Tests_REST_API_RestOutputLinkHeadernpm run test:php -- --filter Tests_REST_API_RestOutputLinkHeader -c tests/phpunit/multisite.xmlnpm run test:php -- --filter Tests_REST_API_RestOutputLinkHeader --order-by=randomnpm run test:php -- --group restapiUse of AI Tools