[shail-mehta]

Trac ticket: #65819

What

Adds a dedicated PHPUnit class for rest_are_values_equal(), covering scalar equality, int/float coercion, nested arrays, object key order, and unequal values.

Test-only; no production code changes.

Why

rest_are_values_equal() had no direct @covers coverage. Small helper coverage fits the #65819 test cleanup track.

How

Add tests/phpunit/tests/rest-api/restAreValuesEqual.php with @covers ::rest_are_values_equal.

• Equal scalars, nulls, lists, and objects (including different key order)
• Int/float values compare equal when numerically the same
• Unequal strings, types, list order, counts, missing keys, and nested mismatches return false

Testing Instructions

1. npm run test:php -- --filter Tests_REST_API_RestAreValuesEqual
2. npm run test:php -- --filter Tests_REST_API_RestAreValuesEqual -c tests/phpunit/multisite.xml
3. npm run test:php -- --filter Tests_REST_API_RestAreValuesEqual --order-by=random
4. npm run test:php -- --group restapi

Use of AI Tools

• Cursor

[Copilot]

🟡 Changes recommended

The equality tests miss unequal integer–float pairs, matching null-valued properties, and nested coercion or reordered keys, leaving REST enum regressions undetected.

3 open issues

• Test matching arrays or objects with null-valued properties · New
• Test nested numeric coercion and reordered object keys · New
• Test unequal mixed-number pairs in both argument orders · New

What changed in this PR

Adds direct PHPUnit coverage for the REST API equality helper rest_are_values_equal(), supporting the test cleanup work in Trac #65819. No production code changes.

Changes:

• Adds a dedicated test class with @covers metadata and the restapi group.
• Tests scalar equality, numeric coercion, array ordering, nested values, and unequal inputs through data providers.

File	Description
tests/​phpunit/​tests/​rest-api/​restAreValuesEqual.php	Adds data-driven tests for equal and unequal REST values.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are recorded for this test-only change.

No open issues 🎉

3 resolved since last review

• Test unequal mixed-number pairs in both argument orders
• Test nested numeric coercion and reordered object keys
• Test matching arrays or objects with null-valued properties

_{Review effort: Balanced}

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[lancewillett]

Direct comparator checks include meaningful nested numeric coercion, reordered keys, and null-valued properties. Existing schema tests overlap scalar/list cases but do not justify rejecting the whole patch.

Local randomized single-site and multisite checks passed alongside related existing tests; PHPCS passed.

Optional: Trim 18 rows to distinct outcomes, especially repeated scalar identity cases. Keep null-valued keys and nested coercion; no extra edge matrix.

_{AI review · gpt-6}

[lancewillett]

PR #15285 landed in https://core.trac.wordpress.org/changeset/65141