Skip to content

Tests: Make data providers in functions, media, meta, and vars tests public static #15310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devmuhib009 wants to merge 1 commit into from
Closed

Tests: Make data providers in functions, media, meta, and vars tests public static #15310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/phpunit/tests/functions/_wpCheckExistingFileNames.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function test_wp_check_existing_file_names( $filename, $files, $expected
*
* @return array[]
*/
public function data_wp_check_existing_file_names() {
public static function data_wp_check_existing_file_names() {
return array(
'no size' => array(
'filename' => 'filename.php',
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/media/getMediaEmbeddedInContent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function test_returns_expected_media( $content, $types, $expected ) {
*
* @return array[]
*/
public function data_content() {
public static function data_content() {
$audio = '<audio preload="none"><source /></audio>';
$video = '<video preload="none"><source /></video>';
$iframe = '<iframe src="https://example.com/embed" width="700"></iframe>';
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/meta.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ public function test_get_metadata_with_non_existent_object_id( $expected, $args
$this->assertSame( $expected, get_metadata( 'user', ...$args ) );
}

public function data_get_metadata_with_non_existent_object_id() {
public static function data_get_metadata_with_non_existent_object_id() {
return array(
'should return empty array for default `$meta_key` and `$single` values' => array(
'expected' => array(),
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/vars.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public function tear_down() {
*
* @return array
*/
public function get_data_to_test_wp_is_mobile(): array {
public static function get_data_to_test_wp_is_mobile(): array {
return array(
'mobile client hint' => array(
'headers' => array(
Expand Down
Loading