Repository navigation
Tests: Cover format_to_edit() #15317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
devmuhib009
wants to merge
1
commit into
WordPress:trunk
from
devmuhib009:tests/65819-cover-format-to-edit
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Tests for the `format_to_edit()` function. | ||
| * | ||
| * @group formatting | ||
| * | ||
| * @covers ::format_to_edit | ||
| */ | ||
| class Tests_Formatting_FormatToEdit extends WP_UnitTestCase { | ||
|
|
||
| /** | ||
| * Tests that format_to_edit() escapes text for textarea by default ($rich_text = false). | ||
| * | ||
| * @ticket 65819 | ||
| */ | ||
| public function test_format_to_edit_escapes_when_rich_text_is_false() { | ||
| $content = '<b>"hello" & \'world\'</b>'; | ||
| $expected = '<b>"hello" & 'world'</b>'; | ||
|
|
||
| $this->assertSame( $expected, format_to_edit( $content ) ); | ||
| $this->assertSame( $expected, format_to_edit( $content, false ) ); | ||
| } | ||
|
|
||
| /** | ||
| * Tests that format_to_edit() does not escape text when $rich_text is true. | ||
| * | ||
| * @ticket 65819 | ||
| */ | ||
| public function test_format_to_edit_does_not_escape_when_rich_text_is_true() { | ||
| $content = '<b>"hello" & \'world\'</b>'; | ||
|
|
||
| $this->assertSame( $content, format_to_edit( $content, true ) ); | ||
| } | ||
|
|
||
| /** | ||
| * Tests that format_to_edit filter modifies content before escaping. | ||
| * | ||
| * @ticket 65819 | ||
| */ | ||
| public function test_format_to_edit_filter() { | ||
| add_filter( | ||
| 'format_to_edit', | ||
| static function ( $text ) { | ||
| return $text . ' & <span>extra</span>'; | ||
| } | ||
| ); | ||
|
|
||
| $expected = 'original & <span>extra</span>'; | ||
|
|
||
| $this->assertSame( $expected, format_to_edit( 'original' ) ); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks like a small coverage gap:
esc_textarea()differs fromesc_html()by double-encoding existing entities, and the class still passes if the function switches toesc_html(). Could you add a case like$this->assertSame( 'AT&amp;T', format_to_edit( 'AT&T' ) );?