[devmuhib009]

Trac ticket: https://core.trac.wordpress.org/ticket/65819

This PR extends Tests_Formatting_StripslashesDeep to cover stripslashes_from_strings_only():

• Stripping slashes from string values
• Preserving non-string data types (integers, floats, booleans, null, arrays)

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props devmuhib, huzaifaalmesbah, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[huzaifaalmesbah]

I left a few small notes inline.

AI Review: Opus 5.5

[huzaifaalmesbah]

This one looks like a small coverage gap: array( 'a', 'b' ) has nothing to strip, so the test still passes if array items start getting stripped. A slashed item would catch it:

Suggested change

	'array' => array( array( 'a', 'b' ) ),
	'array' => array( array( "I can\'t", 'b' ) ),

[huzaifaalmesbah]

Optional: the class docblock already has @covers ::stripslashes_from_strings_only. Feel free to drop this one and the one at line 76.

[Copilot]

🟡 Changes recommended

The array fixture contains no backslashes, so the assertion cannot detect incorrect recursive stripping and needs a backslash-containing string to verify that non-string inputs remain unchanged.

1 open issue

• Array fixture doesn't verify backslashes remain unchanged · New

What changed in this PR

This PR extends WordPress formatting tests to cover stripslashes_from_strings_only(), addressing Trac ticket #65819 without changing production code.

Changes:

• Adds a test verifying slash removal from strings.
• Adds data-driven checks that non-string values remain unchanged.
• Adds coverage annotations for the helper.

File	Description
tests/​phpunit/​tests/​formatting/​stripslashesDeep.php	Adds string and non-string tests for stripslashes_from_strings_only().

_{Review effort: Balanced}

[lancewillett]

Please narrow the added coverage. test_strips_slashes() already exercises this callback through stripslashes_deep(), and test_preserves_original_datatype() already protects integer/boolean preservation. The added string case repeats that regression check. Remove the duplicate string case and avoid repeating the scalar matrix solely for direct coverage. The direct-array contract is distinct, but the current unslashed array does not distinguish it; the existing inline feedback already explains that limitation. Removing redundant additions is sufficient—no additional test matrix is requested.

_{AI review · gpt-6}

[Copilot]

🟢 Approval recommended

No active review issues were identified for the focused array-preservation test addition.

No open issues 🎉

1 resolved since last review

• Array fixture doesn't verify backslashes remain unchanged

_{Review effort: Balanced}

[huzaifaalmesbah]

Thanks for refining this, @devmuhib009! Narrowing the test to stripslashes_from_strings_only()'s non-recursive array contract removes redundancy and cleanly verifies the unique behavior. LGTM!

_{AI Review: Gemini 3.8 Flash}

[lancewillett]

The narrowed test now distinguishes the documented behavior: an array containing a slashed string must pass through stripslashes_from_strings_only() unchanged. The existing recursive tests never pass an array directly to that callback. Removing the duplicate string/scalar cases was useful simplification.

The affected class passes randomized single-site and multisite runs (4 tests, 15 assertions each); PHPCS and CI pass. A controlled callback mutation passed the older tests but failed this new assertion. Approved at 728bb7b.

_{AI review · gpt-6}

[lancewillett]

PR #15325 landed in https://core.trac.wordpress.org/changeset/65188