Tests: Add unit coverage for `get_wp_title_rss()` by shail-mehta · Pull Request #15370 · WordPress/wordpress-develop

shail-mehta · 2026-11-02T16:34:41Z

Trac ticket: #66474

What

Adds a dedicated PHPUnit class for get_wp_title_rss(), covering the get_wp_title_rss filter arguments with a fixed document title.

Test-only; no production code changes.

Why

get_wp_title_rss() had no direct @covers coverage. Document title composition is already covered by wp_get_document_title() tests; this keeps the feed-title filter contract.

How

Add tests/phpunit/tests/feed/getWpTitleRss.php with @covers ::get_wp_title_rss, using pre_get_document_title for a stable title and asserting filter call count and arguments.

Testing Instructions

docker compose up -d mysql
docker compose run --rm php ./vendor/bin/phpunit --filter Tests_Feed_GetWpTitleRss

Expected: OK (1 test, 3 assertions).

Use of AI Tools

Cursor

Cover the get_wp_title_rss filter arguments with a fixed document title. See #65819.

Copilot

🟢 Approval recommended

No active review issues are identified for the test-only addition covering the get_wp_title_rss() filter contract.

No open issues 🎉

What changed in this PR

Adds direct PHPUnit coverage for get_wp_title_rss(), checking its filter contract without duplicating document-title composition tests. No production code changes.

Changes:

Adds a dedicated test class with @covers ::get_wp_title_rss.
Uses a fixed document title and verifies the filtered result, filter call count, and both filter arguments.

File	Description
`tests/phpunit/tests/feed/getWpTitleRss.php`	Adds a test for the feed-title filter’s arguments and returned value.

_{Review effort: Balanced}

github-actions · 2026-11-02T16:47:48Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

@propsbot add <username> to give props to a GitHub user. Requires write access.
@propsbot remove <username> to leave a user out of the props. Requires write access.
@propsbot refresh to refresh this list. Adding the props-bot label works too.

lancewillett

The filtered-title result assertion protects useful behavior. Please keep that assertion and simplify the test by replacing the MockAction with a small callback, removing the call-count and default deprecated-argument assertions. The changed output already proves the filter ran; the unused default argument adds no demonstrated consumer protection here.

One method and one literal output assertion are enough. Targeted single-site/multisite runs and PHPCS pass.

_{AI review · gpt-6}

Copilot

🟡 Changes recommended

The test leaves the filter-argument contract unprotected because its callback accepts only the title and cannot detect a missing or changed second argument.

1 open issue

Test filter arguments and invocation count · New

_{Review effort: Balanced}

+		add_filter(
+			'get_wp_title_rss',
+			static function ( $title ) {
+				return $title . ' Custom';
+			}
+		);
+
+		$this->assertSame( 'Feed Title Custom', get_wp_title_rss() );


lancewillett

Approved at c513488. The test now checks the customized title, as requested. Mutation check: discarding the filter result is caught. On Copilot's thread: the deprecated argument and call count were dropped on purpose in the earlier review, so no change is needed.

1 test, 1 assertion in random order, single site and multisite. PHPCS clean. CI green.

_{AI review · claude-opus-5-5}

lancewillett · 2026-11-03T17:43:45Z

Thanks, @shail-mehta. Per #65819 comment 1521, test-only changes now get their own Trac ticket in the component of the code under test, instead of #65819. That now includes open PRs like this one.

Could you open a new ticket for this change (likely Feeds)? Please add the has-patch and has-unit-tests keywords, and update the Trac link in this PR's description. My approval stands. Once the description links the new ticket, this is ready to land.

_{AI review · claude-opus-5-5}

shail-mehta · 2026-11-04T16:03:31Z

Created Ticket: #66474

Add a test that a callback on the `get_wp_title_rss` filter receives the document title and can change the feed title that `get_wp_title_rss()` returns. Developed in: #15370 Props shailu25. Fixes #66474. git-svn-id: https://develop.svn.wordpress.org/trunk@65257 602fd350-edb4-49c9-b593-d223f7449a82

github-actions · 2026-11-04T16:40:05Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 65257
GitHub commit: 4e4783f

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

Add a test that a callback on the `get_wp_title_rss` filter receives the document title and can change the feed title that `get_wp_title_rss()` returns. Developed in: WordPress/wordpress-develop#15370 Props shailu25. Fixes #66474. Built from https://develop.svn.wordpress.org/trunk@65257 git-svn-id: http://core.svn.wordpress.org/trunk@64406 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Tests: Add unit coverage for get_wp_title_rss().

1fd24f7

Cover the get_wp_title_rss filter arguments with a fixed document title. See #65819.

shail-mehta requested a balanced review from Copilot November 2, 2026 16:34

Copilot started reviewing on behalf of shail-mehta November 2, 2026 16:35

View session

Copilot AI reviewed Nov 2, 2026

View reviewed changes

shail-mehta marked this pull request as ready for review November 2, 2026 16:47

shail-mehta requested a review from lancewillett November 2, 2026 16:47

lancewillett requested changes Nov 2, 2026

View reviewed changes

shail-mehta added 2 commits November 3, 2026 10:08

Merge branch 'trunk' into tests/65819-cover-get-wp-title-rss

0ee3de8

Apply Feedback changes

c513488

shail-mehta requested a balanced review from Copilot November 3, 2026 04:40

Copilot started reviewing on behalf of shail-mehta November 3, 2026 04:41

View session

Copilot AI reviewed Nov 3, 2026

View reviewed changes

Comment thread tests/phpunit/tests/feed/getWpTitleRss.php

Comment on lines +22 to +29

add_filter(

'get_wp_title_rss',

static function ( $title ) {

return $title . ' Custom';

}

);

$this->assertSame( 'Feed Title Custom', get_wp_title_rss() );

shail-mehta requested a review from lancewillett November 3, 2026 04:47

lancewillett approved these changes Nov 3, 2026

View reviewed changes

lancewillett added this to WordPress Project Build Tooling Nov 3, 2026

lancewillett moved this to In review in WordPress Project Build Tooling Nov 3, 2026

github-actions Bot closed this Nov 4, 2026

github-project-automation Bot moved this from In review to Done in WordPress Project Build Tooling Nov 4, 2026

Navigation Menu

Repository navigation

Tests: Add unit coverage for `get_wp_title_rss()` - #15370

Tests: Add unit coverage for `get_wp_title_rss()`#15370
shail-mehta wants to merge 3 commits into
WordPress:trunkfrom
shail-mehta:tests/65819-cover-get-wp-title-rss

shail-mehta commented Nov 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Nov 2, 2026 •

edited

Loading

Uh oh!

lancewillett left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

lancewillett left a comment

Uh oh!

lancewillett commented Nov 3, 2026

Uh oh!

shail-mehta commented Nov 4, 2026

Uh oh!

github-actions Bot commented Nov 4, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

shail-mehta commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

How

Testing Instructions

Use of AI Tools

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

github-actions Bot commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lancewillett left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

lancewillett left a comment

Choose a reason for hiding this comment

Uh oh!

lancewillett commented Nov 3, 2026

Uh oh!

shail-mehta commented Nov 4, 2026

Uh oh!

github-actions Bot commented Nov 4, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shail-mehta commented Nov 2, 2026 •

edited

Loading

github-actions Bot commented Nov 2, 2026 •

edited

Loading