Repository navigation
Tests: Remove redundant null call in get_the_content_feed() coverage - #15394
shail-mehta wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for this test-only cleanup of redundant get_the_content_feed() assertions.
No open issues 🎉
What changed in this PR
This test-only cleanup removes redundant get_the_content_feed() coverage following PR #15348. No production code changes are included.
Changes:
- Removes the explicit
nullcall and its three assertions from the default feed-type test. - Retains the no-argument assertions; explicit
nullwith a customized default remains covered separately.
| File | Description |
|---|---|
tests/phpunit/tests/feed/getTheContentFeed.php |
Removes duplicate assertions from the default feed-type test. |
Review effort: Balanced
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
|
Thanks, @shail-mehta. Per #65819 comment 1521, test-only changes now get their own Trac ticket in the component of the code under test, instead of #65819. That now includes open PRs like this one. Could you open a new ticket for this change (likely Feeds)? Please add the AI review · |
|
Created Ticket: #66475 |
Trac ticket: #66475
Follow Up: #15348
What
Removes the redundant
get_the_content_feed( null )call and its three assertions fromTests_Feed_GetTheContentFeed::test_returns_filtered_content_for_default_feed_type().Test-only; no production code changes.
Why
Follow-up to Lance’s optional cleanup note on the landed coverage: the no-argument call already passes the default
nullvalue, so the explicitnullinvocation in that method adds no distinct protection. Explicitnullwith a customizeddefault_feedremains covered bytest_null_feed_type_uses_default_feed().How
Delete the second
get_the_content_feed( null )call and its matching output/call-count/argument assertions from the default feed-type test method.Testing Instructions
Expected: OK (4 tests).
Use of AI Tools