Skip to content

Tests: Add unit coverage for bloginfo_rss() - #15425

Open
shail-mehta wants to merge 2 commits into
WordPress:trunkfrom
shail-mehta:tests/65819-cover-bloginfo-rss
Open

shail-mehta wants to merge 2 commits into
WordPress:trunkfrom
shail-mehta:tests/65819-cover-bloginfo-rss

Conversation

@shail-mehta

@shail-mehta shail-mehta commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Trac ticket: #66478

What

Adds a dedicated PHPUnit class for bloginfo_rss(), covering the bloginfo_rss filter arguments and echoed output.

Test-only; no production code changes.

Why

bloginfo_rss() had no direct @covers coverage. get_bloginfo_rss() already covers value conversion; this keeps the display filter + echo contract.

How

Add tests/phpunit/tests/feed/bloginfoRss.php with @covers ::bloginfo_rss, asserting filter call count, arguments, and output.

Testing Instructions

docker compose up -d mysql
docker compose run --rm php ./vendor/bin/phpunit --filter Tests_Feed_BloginfoRss

Expected: OK (1 test, 3 assertions).

Use of AI Tools

  • Cursor

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for this test-only addition covering the filter and echo behavior of bloginfo_rss().

No open issues 🎉

What changed in this PR

Adds direct PHPUnit coverage for bloginfo_rss() to address Trac #65819, focusing on its display-filter and echo contract. No production code changes.

Changes:

  • Adds a dedicated test class with @covers ::bloginfo_rss.
  • Verifies filtered output, a single filter invocation, and the value and selector passed to the filter.
File Description
tests/​phpunit/​tests/​feed/​bloginfoRss.php Adds one test with three assertions covering filter arguments, call count, and echoed output.

Review effort: Balanced

@shail-mehta
shail-mehta marked this pull request as ready for review November 3, 2026 17:14
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@lancewillett

Copy link
Copy Markdown
Member

Thanks, @shail-mehta. Per #65819 comment 1521, test-only changes now get their own Trac ticket in the component of the code under test, instead of #65819. That now includes open PRs like this one.

Could you open a new ticket for this change (likely Feeds)? Please add the has-patch and has-unit-tests keywords, and update the Trac link in this PR's description. I will review it under the new ticket.

AI review · claude-opus-5-5

@shail-mehta shail-mehta self-assigned this Nov 4, 2026
@shail-mehta

Copy link
Copy Markdown
Member Author

Created Ticket: #66478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants