Skip to content

Tests: Add unit coverage for get_self_link() - #15427

Open
shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:tests/65819-cover-get-self-link
Open

shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:tests/65819-cover-get-self-link

Conversation

@shail-mehta

@shail-mehta shail-mehta commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Trac ticket: #66480

What

Adds a dedicated PHPUnit class for get_self_link(), covering scheme-aware feed self URL construction from REQUEST_URI.

Test-only; no production code changes.

Why

get_self_link() had no direct @covers coverage. It builds the Atom/RSS self link used by feed templates. Small helper coverage fits the #65819 test cleanup track.

How

Add tests/phpunit/tests/feed/getSelfLink.php with @covers ::get_self_link, setting $_SERVER['REQUEST_URI'] and asserting the scheme-aware URL.

Testing Instructions

docker compose up -d mysql
docker compose run --rm php ./vendor/bin/phpunit --filter Tests_Feed_GetSelfLink

## Use of AI Tools
- Cursor

Cover scheme-aware feed self URL construction from REQUEST_URI.

See #65819.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The test exercises only HTTP and would still pass without set_url_scheme(), leaving scheme-aware behavior unprotected without explicit HTTP and HTTPS assertions.

1 open issue
What changed in this PR

Adds dedicated PHPUnit coverage for get_self_link(), the helper that constructs feed self URLs, as part of the #65819 test cleanup effort. No production code changes are included.

Changes:

  • Adds a feed test class with @covers ::get_self_link.
  • Checks URL construction from REQUEST_URI, including a query string and the home URL’s host and optional port.
File Description
tests/​phpunit/​tests/​feed/​getSelfLink.php Adds a direct test of feed self URL construction.

Review effort: Balanced

Comment on lines +23 to +26
$this->assertSame(
set_url_scheme( 'http://' . $domain . '/feed/rss2/?foo=bar' ),
get_self_link()
);
@shail-mehta
shail-mehta marked this pull request as ready for review November 3, 2026 17:15
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@lancewillett

Copy link
Copy Markdown
Member

Thanks, @shail-mehta. Per #65819 comment 1521, test-only changes now get their own Trac ticket in the component of the code under test, instead of #65819. That now includes open PRs like this one.

Could you open a new ticket for this change (likely Feeds)? Please add the has-patch and has-unit-tests keywords, and update the Trac link in this PR's description. I will review it under the new ticket.

AI review · claude-opus-5-5

@shail-mehta shail-mehta self-assigned this Nov 4, 2026
@shail-mehta

Copy link
Copy Markdown
Member Author

Created Ticket: #66480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants