Skip to content

Tests: Add unit coverage for get_term_to_edit() - #15428

Open
shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:tests/65819-cover-get-term-to-edit
Open

shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:tests/65819-cover-get-term-to-edit

Conversation

@shail-mehta

@shail-mehta shail-mehta commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Trac ticket: #66481

What

Adds a dedicated PHPUnit class for get_term_to_edit(), covering edit-context sanitization via the edit_term_name filter.

Test-only; no production code changes.

Why

get_term_to_edit() had no direct @covers coverage. It is used when preparing terms for editing in admin. Small helper coverage fits the #65819 test cleanup track.

How

Add tests/phpunit/tests/term/getTermToEdit.php with @covers ::get_term_to_edit, using a local category fixture and asserting the edit-context filter result.

Testing Instructions

docker compose up -d mysql
docker compose run --rm php ./vendor/bin/phpunit --filter Tests_Term_GetTermToEdit

Expected: OK (1 test, 2 assertions).

Use of AI Tools

  • Cursor

Cover edit-context sanitization via the edit_term_name filter.

See #65819.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the test-only addition covering get_term_to_edit().

No open issues 🎉

What changed in this PR

Adds direct PHPUnit coverage for get_term_to_edit() as part of the #65819 test cleanup effort. The change is test-only; production code is unchanged.

Changes:

  • Adds a dedicated test class with @covers ::get_term_to_edit.
  • Creates a category fixture and verifies that the helper returns a WP_Term with the name modified by the edit_term_name filter.
File Description
tests/​phpunit/​tests/​term/​getTermToEdit.php Adds a test for edit-context term-name filtering.

Review effort: Balanced

@shail-mehta
shail-mehta marked this pull request as ready for review November 3, 2026 17:16
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@lancewillett

Copy link
Copy Markdown
Member

Thanks, @shail-mehta. Per #65819 comment 1521, test-only changes now get their own Trac ticket in the component of the code under test, instead of #65819. That now includes open PRs like this one.

Could you open a new ticket for this change (likely Taxonomy)? Please add the has-patch and has-unit-tests keywords, and update the Trac link in this PR's description. I will review it under the new ticket.

AI review · claude-opus-5-5

@shail-mehta shail-mehta self-assigned this Nov 4, 2026
@shail-mehta

Copy link
Copy Markdown
Member Author

Created Ticket: #66481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants