Skip to content

Tests: Clean up custom post types in Tests_Link - #15443

Open
devmuhib009 wants to merge 1 commit into
WordPress:trunkfrom
devmuhib009:tests/65893-clean-up-link
Open

devmuhib009 wants to merge 1 commit into
WordPress:trunkfrom
devmuhib009:tests/65893-clean-up-link

Conversation

@devmuhib009

Copy link
Copy Markdown
Member

Unregisters custom post types wptests_pt and not_a_post_type during tear_down() in Tests_Link.

Trac ticket: https://core.trac.wordpress.org/ticket/65893

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props devmuhib.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the change adding custom post-type cleanup after each test.

No open issues 🎉

What changed in this PR

This PR improves test isolation in Tests_Link by cleaning up custom post types after each test.

Changes:

  • Adds tear_down() to unregister wptests_pt and not_a_post_type.
  • Preserves the base test cleanup by calling parent::tear_down().
File Description
tests/​phpunit/​tests/​link.php Adds teardown cleanup for two custom post types.

Review effort: Balanced

@huzaifaalmesbah huzaifaalmesbah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devmuhib009!

Adds tear_down() to cleanly unregister wptests_pt and not_a_post_type in Tests_Link. Verified test isolation. Looks good!

AI Review: Gemini 3.8 Flash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants