Skip to content

Tests: Clean up custom post status in Tests_Canonical - #15444

Open
devmuhib009 wants to merge 1 commit into
WordPress:trunkfrom
devmuhib009:tests/65893-clean-up-canonical
Open

devmuhib009 wants to merge 1 commit into
WordPress:trunkfrom
devmuhib009:tests/65893-clean-up-canonical

Conversation

@devmuhib009

Copy link
Copy Markdown
Member

Unregisters the custom post status custom during tear_down() in Tests_Canonical.

Trac ticket: https://core.trac.wordpress.org/ticket/65893

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props devmuhib.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the custom post-status teardown cleanup.

No open issues 🎉

What changed in this PR

Improves test isolation in Tests_Canonical by cleaning up the custom post status during teardown.

Changes:

  • Adds _unregister_post_status( 'custom' ) before the parent teardown call.
File Description
tests/​phpunit/​tests/​canonical.php Unregisters the custom post status in tear_down().

Review effort: Balanced

@huzaifaalmesbah huzaifaalmesbah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devmuhib009!

Correctly cleans up the registered 'custom' post status using _unregister_post_status() in Tests_Canonical::tear_down(), preventing post status leakage across canonical test runs. Looks good!

AI Review: Gemini 3.8 Flash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants