Skip to content

Tests: Clean up cpt_template_null in WP_Test_REST_Post_Types_Controller - #15445

Open
devmuhib009 wants to merge 1 commit into
WordPress:trunkfrom
devmuhib009:tests/65893-clean-up-rest-post-types-controller
Open

devmuhib009 wants to merge 1 commit into
WordPress:trunkfrom
devmuhib009:tests/65893-clean-up-rest-post-types-controller

Conversation

@devmuhib009

Copy link
Copy Markdown
Member

Unregisters the custom post type cpt_template_null during tear_down() in WP_Test_REST_Post_Types_Controller.

Trac ticket: https://core.trac.wordpress.org/ticket/65893

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props devmuhib.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the added cpt_template_null teardown cleanup.

No open issues 🎉

What changed in this PR

This PR improves test isolation in WP_Test_REST_Post_Types_Controller by cleaning up the cpt_template_null custom post type after each test.

Changes:

  • Adds unregister_post_type( 'cpt_template_null' ) to tear_down(), alongside existing post type cleanup.
File Description
tests/​phpunit/​tests/​rest-api/​rest-post-types-controller.php Unregisters cpt_template_null during teardown.

Review effort: Balanced

@huzaifaalmesbah huzaifaalmesbah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devmuhib009!

Adds proper cleanup for cpt_template_null alongside the other CPTs in WP_Test_REST_Post_Types_Controller::tear_down(). Looks good!

AI Review: Gemini 3.8 Flash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants